Skip to contentSkip to conversation

tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()

PATCH Superseded Sergei Shtylyov 3 participants 4 messages Sep 14, 2014 – Sep 18, 2014

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()

I spent a couple of days with the driver just hanging due to me forgetting to specify the external crystal frequency, so that clk_get_rate() returned 0 and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an acceptable behavior, so I suggest that the minimum frequency is checked for 0 in tmio_mmc_host_probe().

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.

Changes in version 3:
- added Cc: stable.

Changes in version 2:
- fixed grammar in the changelog.

 drivers/mmc/host/tmio_mmc_pio.c |    9 +++++++++
 1 file changed, 9 insertions(+)
drivers/mmc/host/tmio_mmc_pio.c +9 -0
Index: mmc/drivers/mmc/host/tmio_mmc_pio.c
===================================================================
@@ -1044,6 +1044,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_
 	}
 
 	/*
+	 * Check the sanity of mmc->f_min to prevent tmio_mmc_set_clock() from
+	 * looping forever...
+	 */
+	if (mmc->f_min == 0) {
+		ret = -EINVAL;
+		goto pm_disable;
+	}
+
+	/*
 	 * There are 4 different scenarios for the card detection:
 	 *  1) an external gpio irq handles the cd (best for power savings)
 	 *  2) internal sdhi irq handles the cd
Acked-by on v3 1/1
#1 lore raw

Seems reasonable,

-Ian

Quoted 41 lines · On Sun, 14 Sep 2014 23:51:24 +0400 Sergei Shtylyov…

I spent a couple of days with the driver just hanging due to me forgetting to specify the external crystal frequency, so that clk_get_rate() returned 0 and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an acceptable behavior, so I suggest that the minimum frequency is checked for 0 in tmio_mmc_host_probe().

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.

Changes in version 3:
- added Cc: stable.

Changes in version 2:
- fixed grammar in the changelog.

 drivers/mmc/host/tmio_mmc_pio.c |    9 +++++++++
 1 file changed, 9 insertions(+)

Index: mmc/drivers/mmc/host/tmio_mmc_pio.c =================================> --- mmc.orig/drivers/mmc/host/tmio_mmc_pio.c +++ mmc/drivers/mmc/host/tmio_mmc_pio.c

drivers/mmc/host/tmio_mmc_pio.c +9 -0
@@ -1044,6 +1044,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_
 	}
 
 	/*
+	 * Check the sanity of mmc->f_min to prevent tmio_mmc_set_clock() from
+	 * looping forever...
+	 */
+	if (mmc->f_min = 0) {
+		ret = -EINVAL;
+		goto pm_disable;
+	}
+
+	/*
 	 * There are 4 different scenarios for the card detection:
 	 *  1) an external gpio irq handles the cd (best for power savings)
 	 *  2) internal sdhi irq handles the cd
Signature · 1 line
Ian Molton <[email protected]>
#2 lore raw
In reply to Sergei Shtylyov
Quoted 11 lines · Sergei Shtylyov

I spent a couple of days with the driver just hanging due to me forgetting to specify the external crystal frequency, so that clk_get_rate() returned 0 and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an acceptable behavior, so I suggest that the minimum frequency is checked for 0 in tmio_mmc_host_probe().

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.

Hi Sergei,

Could you please rebase it towards next instead?

Kind regards
Uffe

Quoted 30 lines

Changes in version 3:
- added Cc: stable.

Changes in version 2:
- fixed grammar in the changelog.

 drivers/mmc/host/tmio_mmc_pio.c |    9 +++++++++
 1 file changed, 9 insertions(+)

Index: mmc/drivers/mmc/host/tmio_mmc_pio.c =================================> --- mmc.orig/drivers/mmc/host/tmio_mmc_pio.c +++ mmc/drivers/mmc/host/tmio_mmc_pio.c

drivers/mmc/host/tmio_mmc_pio.c +9 -0
@@ -1044,6 +1044,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_
        }
 
        /*
+        * Check the sanity of mmc->f_min to prevent tmio_mmc_set_clock() from
+        * looping forever...
+        */
+       if (mmc->f_min = 0) {
+               ret = -EINVAL;
+               goto pm_disable;
+       }
+
+       /*
         * There are 4 different scenarios for the card detection:
         *  1) an external gpio irq handles the cd (best for power savings)
         *  2) internal sdhi irq handles the cd
#3 lore raw

Hello.

Quoted 9 lines · Ulf Hansson
Quoted 8 lines

I spent a couple of days with the driver just hanging due to me forgetting to specify the external crystal frequency, so that clk_get_rate() returned 0 and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an acceptable behavior, so I suggest that the minimum frequency is checked for 0 in tmio_mmc_host_probe().

Quoted 6 lines
Quoted 2 lines

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.

Hi Sergei,

Could you please rebase it towards next instead?

Ah, I've misinterpreted your mail, thought that I should either rebase to
next /or/ CC: stable. Will do.

Quoted 2 lines

Kind regards
Uffe

WBR, Sergei