power, max8998: Include linux/module.h just once in drivers/power/max8998_charger.c
함명주
Acked-byQuoted 3 lines
Remove the duplicate.
Signed-off-by Jesper Juhl <[email protected]>
Quoted 25 lines
--- drivers/power/max8998_charger.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/power/max8998_charger.c +0
-1@@ -21,7 +21,6 @@#include <linux/module.h> #include <linux/err.h> -#include <linux/module.h> #include <linux/slab.h> #include <linux/platform_device.h> #include <linux/power_supply.h> Signature · 7 lines
1.7.9 -- Jesper Juhl <[email protected]> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay� ���,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�
Anton Vorontsov
AppliedQuoted 5 lines · 함명주
Quoted 3 lines
Remove the duplicate.
Signed-off-by Jesper Juhl <[email protected]>Acked-by MyungJoo Ham <[email protected]>
Applied, thanks!
Quoted 19 lines
Quoted 19 lines
--- drivers/power/max8998_charger.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/power/max8998_charger.c +0
-1@@ -21,7 +21,6 @@#include <linux/module.h> #include <linux/err.h> -#include <linux/module.h> #include <linux/slab.h> #include <linux/platform_device.h> #include <linux/power_supply.h> Signature · 1 line
1.7.9
Signature · 2 lines
Anton Vorontsov Email: [email protected]
Quoted 8 lines · Anton Vorontsov
Quoted 5 lines · 함명주
Quoted 3 lines
Remove the duplicate.
Signed-off-by Jesper Juhl <[email protected]>Acked-by MyungJoo Ham <[email protected]>Applied, thanks!
There is already a commit queued in linux-next that deletes all the duplicates at once. It just so happens to delete the other instance vs the one shown here. So if both commits are present, then there won't be *any* module.h left, and the build will fail. If it is possible, please just drop this patch, since the treewide duplicate patch will still have to exist to fix the other instances.
https://lkml.org/lkml/2012/2/29/586
Thanks,
Paul.
Quoted 21 lines
Quoted 20 lines
Quoted 20 lines
--- drivers/power/max8998_charger.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/power/max8998_charger.c +0
-1@@ -21,7 +21,6 @@#include <linux/module.h> #include <linux/err.h> -#include <linux/module.h> #include <linux/slab.h> #include <linux/platform_device.h> #include <linux/power_supply.h> Signature · 1 line
1.7.9
Quoted 18 lines · Paul Gortmaker
Quoted 8 lines · Anton Vorontsov
Quoted 5 lines · 함명주
Quoted 3 lines
Remove the duplicate.
Signed-off-by Jesper Juhl <[email protected]>Acked-by MyungJoo Ham <[email protected]>Applied, thanks!
There is already a commit queued in linux-next that deletes all the duplicates at once. It just so happens to delete the other instance vs the one shown here. So if both commits are present, then there won't be *any*
module.hleft, and the build will fail. If it is possible, please just drop this patch, since the treewide duplicate patch will still have to exist to fix the other instances.
Quoted 2 lines
I agree. Drop this one.
Signature · 3 lines
Jesper Juhl <[email protected]> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.