Skip to contentSkip to conversation

Fix an old sky2 WOL regression

PATCH [email protected] 1 participant 1 message May 4, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Dear Knut,

I am sorry it took a while to try it due to other commitments, however I can now confirm the patch works on my ASUS P5LD2 motherboard.

Many thanks
Nicola

Quoted 1 line · Knut Petersen

Sky2 Wake on LAN is broken since February 2010 on a number of

systems.

Quoted 3 lines

Yes. More than two years.

We know about the problem and

the cause since October 2010

Quoted 1 line

(Bugzilla bug #19492). It´s commit

87b09f1f25cd1e01d7c50bf423c7fe33027d7511.

Quoted 2 lines

Stephen, David: You

signed off that commit.

Quoted 2 lines

Andrew: You called it a regression in

October 2010.

Quoted 2 lines

It has been proposed to revert the commit that caused

the problem.

Quoted 3 lines

Nothing happened.

I proposed to re-establish the old

code for dmi_match()ed systems.

Quoted 3 lines

Without success.

Now it is

proposed to re-establish the old code as a configuration option.

Quoted 1 line

If

nothing happens again I will propose a module parameter ;-)

Quoted 2 lines

Stephen, I don´t want to be a pain in the neck, and it is not my intention

Quoted 1 line

to offend you by my "attitude". But I simply cannot

understand why this

Quoted 1 line

know regression is not fixed. The bit we talk

about is documented,

Quoted 1 line

and in fact it was set for a number of kernel

versions unconditionally.

Quoted 1 line

Nobody complained about ruined hardware or

minor problems.

Quoted 2 lines

The systems affected are old enough that no

manufacturer cares about

Quoted 1 line

them, but they are still quite usable for a

lot of jobs (kernel 3.3 compile

Quoted 3 lines

time here is below 15 minutes).

If there is a problem in the kernel and if we do know an easy solution,

Quoted 1 line

that solution should be commited to the kernel, no matter what is

written

Quoted 1 line

in some random documentation, no matter if we could blame

some

Quoted 1 line

BIOS authors. That´s the way Linux works - at least I thought

so.

Quoted 3 lines

cu,
Knut