2.4.8-pre3 drivers/usb/storage/scsiglue.c
Subsystems (2)
PATCH 1/1 2.4.8-pre3 drivers/usb/storage/scsiglue.c
Trivial patch to remove warning message.
Index: 8-pre3.1/drivers/usb/storage/scsiglue.c
drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 12:07:28 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644) renamed from drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 11:09:45 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644) +1 -1
@@ -249,7 +249,7 @@ static int bus_reset( Scsi_Cmnd *srb ) for (i = 0; i < us->pusb_dev->actconfig->bNumInterfaces; i++) { struct usb_interface *intf = &us->pusb_dev->actconfig->interface[i]; - struct usb_device_id *id; + const struct usb_device_id *id; /* if this is an unclaimed interface, skip it */ if (!intf->driver) {
Hrm... there was a good reason at one point why this shouldn't be const....
Oh yeah... it's not const. id gets assigned a few lines down.
Or does the const keywork refer only to the struct, not to the pointer? If that's the case, then the keyword should be there....
Matt Dharm
Quoted 14 lines · Keith Owens
Trivial patch to remove warning message.
Index:
8-pre3.1/drivers/usb/storage/scsiglue.cdrivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 12:07:28 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644) renamed from drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 11:09:45 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644) +1
-1@@ -249,7 +249,7 @@ static int bus_reset( Scsi_Cmnd *srb ) for (i = 0; i < us->pusb_dev->actconfig->bNumInterfaces; i++) { struct usb_interface *intf = &us->pusb_dev->actconfig->interface[i]; - struct usb_device_id *id; + const struct usb_device_id *id; /* if this is an unclaimed interface, skip it */ if (!intf->driver) {
Signature · 6 lines
Matthew Dharm Home: [email protected] Maintainer, Linux USB Mass Storage Driver I'm a pink gumdrop! How can anything be worse?!! -- Erwin User Friendly, 10/4/1998
Quoted 2 lines · Matthew Dharm
Or does the const keywork refer only to the struct, not to the pointer? If that's the case, then the keyword should be there....
const refers to the structure, not the pointer to the structure.