Skip to contentSkip to conversation

3.2.38 most of the time has 100% cpu use reported

DISCUSSION Zhenzhong Duan 1 participant 1 message Feb 16, 2013

lore
Share & tools
lore

Zhenzhong Duan

author Acked-by
#0 lore raw

On Sat, Feb 16, 2013 at 05:18:10AM +0000, Ben Hutchings wrote:

Quoted 131 lines · On Fri, 2013-02-15 at 22:23 -0500, [email protected] wrote:
Quoted 3 lines · Ben Hutchings
Quoted 2 lines · On Tue, 2013-02-12 at 00:01 -0500, [email protected] wrote:
Quoted 1 line

Okay, I finally have located the patch causing this bizzare

problem

Quoted 1 line
Quoted 1 line
Quoted 1 line

for me. Before I discuss it, I'm going to drag out the kernel

bug reporting

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

guidelines and try to make a proper bug report out of this.

[1.] One line summary of the problem:
3.2.38 most of the time has 100% cpu use reported

[2.] Full description of the problem/report:
Reverse applying the patch for

[9a1f08a1a192f9177d7063d903773aed800b840f]

drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

on top of a clean 3.2.38 tree makes the problem go away.

[...]

Quoted 1 line

I have to admit I have no idea what the patch I'm reversing

actually does,

Quoted 2 lines
Quoted 2 lines

It changes how we look for the version of a BIOS interface (DMI

or

Quoted 1 line
Quoted 1 line

SMBIOS). All the code that it touches, and the version number

variable,

Quoted 1 line
Quoted 1 line

are discarded after boot and therefore can have very limited

effect on

Quoted 3 lines
Quoted 1 line

what happens later!

Actually upon poking about, I noticed something VERY different about

what

Quoted 1 line

the patch does to my computer during the boot process. Let me show

you

Quoted 1 line

dmesg output from a good kernel without the patch, then a bad one

with the

Quoted 1 line

patch, then I'll point out the important differences I noticed:

[...]

Quoted 1 line

Important bits I noticed: The 'bad' kernel initially boots with

acpi

Quoted 1 line

disabled, then later turns it back on, whereas the 'good' one boots

with

Quoted 3 lines

acpi completely enabled with no problems.

Also, very early on just after yelling about the NX bit not existing

in my

Quoted 6 lines

cpu, it says this: (-good/+bad)

-[    0.000000] DMI 2.3 present.
-[    0.000000] DMI: ECS M848A/M848A, BIOS 07.00T 04/02/01
+[    0.000000] Legacy DMI 0.0 present.
+[    0.000000] DMI:  , BIOS  

Oh wow, this has really gone very wrong.

Quoted 1 line

The 'good' kernel without the patch finds something for DMI (That is

in fact

Quoted 1 line

my motherboard model number, so I know it's doing *something* right)

whereas

Quoted 3 lines

the bad one with the patch... Does not.

Anyway, I suppose I could try using acpi=force as the kernel

suggests for a

Quoted 1 line

workaround for now, but I'm still convinced something went wrong

with that

Quoted 1 line

patch now more than ever. Due to the fact that ACPI gets reenabled

I didn't

Quoted 1 line

catch on that something was going wrong so early in the boot process

with it

Quoted 3 lines

until now.

One thing I want to emphasize is that the only difference between

the two

Quoted 3 lines

kernels is that lone patch.

As for perf top, I tried running it as you suggested, but I honestly

can't

Quoted 1 line

figure out how to get this thing to dump output to a file. Every

time I

Quoted 1 line

redirect stdio/stderr I get a empty file, I don't know what I'm

doing wrong.

Quoted 1 line

Any tips?

[...]

Don't worry about it - I think the log messages are a pretty good clue.

Does this patch fix the log messages and/or the other issues?

drivers/firmware/dmi_scan.c +3 -0
@@ -416,6 +416,9 @@ static int __init dmi_present(const char __iomem
 *p)
 
 	memcpy_fromio(buf, p, 15);
 	if (dmi_checksum(buf, 15)) {
+		print_hex_dump(KERN_INFO, "DMI entry: ", DUMP_PREFIX_NONE,
+			       16, 1, buf, 15, false);
+
 		dmi_num = (buf[13] << 8) | buf[12];
 		dmi_len = (buf[7] << 8) | buf[6];
drivers/firmware/dmi_scan.c +3 -1
 		dmi_base = (buf[11] << 24) | (buf[10] << 16) |
@@ -442,10 +445,12 @@ static int __init dmi_present(const char __iomem
 *p)
 static int __init smbios_present(const char __iomem *p)
 {
 	u8 buf[32];
-	int offset = 0;
 
 	memcpy_fromio(buf, p, 32);
 	if ((buf[5] < 32) && dmi_checksum(buf, buf[5])) {
+		print_hex_dump(KERN_INFO, "SMBIOS entry: ", DUMP_PREFIX_NONE,
+			       16, 1, buf, 16, false);
+
 		dmi_ver = (buf[6] << 8) + buf[7];
 
drivers/firmware/dmi_scan.c +2 -2
 		/* Some BIOS report weird SMBIOS version, fix that up */
@@ -461,9 +466,9 @@ static int __init smbios_present(const char
 __iomem *p)
 			dmi_ver = 0x0206;
 			break;
 		}
-		offset = 16;
+		return dmi_present(p + 16);
 	}
-	return dmi_present(buf + offset);
+	return 1;
 }
 
Quoted 2 lines

void __init dmi_scan_machine(void)
--- END ---

Thanks Ben fix it.