Why is there still git-rebase--am.sh?
Hi,
I was wandering in rebase’s source code, and found out that even though run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea ("built-in rebase: call git am directly", 2019-01-18), this commit did not remove the code to call it. I guess it was an oversight.
Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the rebase.useBuiltin setting", 2019-03-18), I would expect this file to be completely removed, too.
May I send a patch to remove git-rebase--am.sh, or is there a reason to keep it?
Cheers,
Alban
Hi Alban,
Quoted 7 lines · Alban Gruin
Hi,
I was wandering in rebase’s source code, and found out that even though
run_specific_rebase()no longer callsgit-rebase--am.shsince21853626ea("built-in rebase: callgit amdirectly", 2019-01-18), this commit did not remove the code to call it. I guess it was an oversight.
Quoted 8 lines
Now that
git-legacy-rebase.shis gone (sinced03ebd411c, "rebase: remove the rebase.useBuiltin setting", 2019-03-18), I would expect this file to be completely removed, too.May I send a patch to remove
git-rebase--am.sh, or is there a reason to keep it?
What's cooking (May 2019, #05; Thu, 30) has it in js/rebase-cleanup (2019-05-15) 5 commits, and will be cooked in next. Philip