power: max17042_battery: Add DT bindings
Dear Karol Lewandowski,
I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
Anyway, the patches themselves look fine.
However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
Thank you.
Cheers!
MyungJoo.
------- Original Message -------
Sender : Karol Lewandowski<[email protected]> Junior Software Engineer/SPRC-Linux (MSD)/삼성전자 Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power: max17042_battery: Add DT bindings
Dear MyungJoo Ham,
Could you take a look at patchset I've sent? It's needed to make use of max17042 driver on device tree-enabled platforms.
Regards,
Signature · 1 line
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
Quoted 24 lines · Karol Lewandowski
Hi,
This series of patches adds bindings to
max17042_batterydriver making it possible to instantiate it from device tree description.First, convience patch, simply replaces kzalloc with
devm_kzallocwhere possible.Second, most intrusive patch adds variables orginally found only in platform data to
max17042_chipstructure. I decided it to do it that way rather than allocating new platform data and then populating it from device tree description.Last patch adds DT bindings itself.
I would be grateful for any comments and I will be more than happy to rework this patchset if needed.
Karol Lewandowski (3):
max17042_battery: Usedevm_kzalloc()where applicable
max17042_battery: Preserve properties outside of platform data
max17042_battery: Make it possible to instantiate driver from DT
Quoted 5 lines
.../bindings/power_supply/max17042_battery.txt | 18 +++++ drivers/power/max17042_battery.c | 77 ++++++++++++++++---- 2 files changed, 79 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/power_supply/max17042_battery.txt
--
MyungJoo Ham (함명주), PHD
System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay� ���,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�
Dear MungJoo,
I wasn't aware of Dirk's patchset and thus, I didn't ever try to make my patches compatible with it.
I've found hopefully correct patchset[1] via google - it's mailing list posting without any feedback... I've checked linux-next and it clearly hasn't been merged.
I'm happy to rework my patch but I would like to ask you about specific tree I should base on. Is this patchset in some subsystem-specific (power?) tree? Other?
[1] https://lkml.org/lkml/2012/1/24/237
Regards,
Signature · 1 line
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
Quoted 27 lines · 함명주
Dear Karol Lewandowski,
I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
Anyway, the patches themselves look fine.
However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
Thank you.
Cheers!
MyungJoo.------- Original Message -------
Sender : Karol Lewandowski<[email protected]> Junior Software Engineer/SPRC-Linux (MSD)/삼성전자 Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power:max17042_battery: Add DT bindingsDear MyungJoo Ham,
Could you take a look at patchset I've sent? It's needed to make use of max17042 driver on device tree-enabled platforms.
Regards,