Skip to contentSkip to conversation

misc: add driver support for MAX8997 MUIC

PATCH MyungJoo Ham 3 participants 3 messages Dec 15, 2011

lore
Share & tools
lore
#0 lore raw
Quoted 16 lines · Samuel Ortiz
Quoted 8 lines · Donggeun Kim
Quoted 3 lines

The MUIC function in MAX8997 device can be used as a USB port detector and switch.
This patch supports the MUIC feature of MAX8997.

I'm queueing this one to my for-next branch as it depends on your previous MFD patch.
I'm also cc'ing Arnd in case he has some objections.

Thanks for the notification!

First of all, every new user space interface including new sysfs files and uevent messages needs documentation in the Documentation/ABI directory.

Quoted 5 lines

The part that is not clear to me is how this new driver fits in with the first fsa9480 driver and the currently discussed extcon subsystem, apparently all written by the same team at Samsung. Is this misc driver still useful when the extcon framework gets merged?

When extcom gets merged, this driver should be updated. It looks like allowing the interrupt handler to update extcon state would be enough. Bascially, this is all this driver is required for extcon to work. (and the prvious author of extcon--"extended" switch class at that time--was the author of this patch.)

Anyway, this patch has just told me that I'll need to add more sysfs entries for extcon to show the list of cable names and/or to show the status for each of them, soon or later.

Quoted 7 lines

I very much believe that we should avoid introducing user interfaces in a driver specific way when we have multiple pieces of hardware that try to do the same thing. The extcon subsystem seems to handle this correctly on the high-level (I have not done a detailed review yet but I trust that it will be ok), so I don't understand why we want another driver for the MAX8997 MUIC.

This sysfs entry is a bit confusing to me (that userspace may update this CONTROL register). I'll consult Donggeun when he arrives and will write again about this one. If it is not writable, this is supported by extcon framework, so this sysfs entry will disappear adapting extcon.

Cheers!
MyungJoo �淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw
Quoted 8 lines · MyungJoo Ham
Quoted 6 lines · Arnd Bergmann

On Monday 12 December 2011, Samuel Ortiz wrote:
The part that is not clear to me is how this new driver fits in with the first fsa9480 driver and the currently discussed extcon subsystem, apparently all written by the same team at Samsung. Is this misc driver still useful when the extcon framework gets merged?

Quoted 8 lines

When extcom gets merged, this driver should be updated. It looks like allowing the interrupt handler to update extcon state would be enough. Bascially, this is all this driver is required for extcon to work. (and the prvious author of extcon--"extended" switch class at that time--was the author of this patch.)

Anyway, this patch has just told me that I'll need to add more sysfs entries for extcon to show the list of cable names and/or to show the status for each of them, soon or later.

I think it would be better not to merge this driver until the user interface in the extcon framework has been finalized. I don't mind the driver, but I want to prevent user interfaces from appearing in the kernel that we intend to change anyway.

How about dropping the driver from the mfd tree, and adding it into the extcon series for the next posting?

Arnd

#2 lore raw

Hi Arnd,

Quoted 18 lines · Arnd Bergmann
Quoted 8 lines · MyungJoo Ham
Quoted 6 lines · Arnd Bergmann

On Monday 12 December 2011, Samuel Ortiz wrote:
The part that is not clear to me is how this new driver fits in with the first fsa9480 driver and the currently discussed extcon subsystem, apparently all written by the same team at Samsung. Is this misc driver still useful when the extcon framework gets merged?

Quoted 8 lines

When extcom gets merged, this driver should be updated. It looks like allowing the interrupt handler to update extcon state would be enough. Bascially, this is all this driver is required for extcon to work. (and the prvious author of extcon--"extended" switch class at that time--was the author of this patch.)

Anyway, this patch has just told me that I'll need to add more sysfs entries for extcon to show the list of cable names and/or to show the status for each of them, soon or later.

Quoted 7 lines

I think it would be better not to merge this driver until the user interface in the extcon framework has been finalized. I don't mind the driver, but I want to prevent user interfaces from appearing in the kernel that we intend to change anyway.

How about dropping the driver from the mfd tree, and adding it into the extcon series for the next posting?

Sounds good to me, I'll drop it.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/