Skip to contentSkip to conversation

bfa: remove unused pci_slot from struct bfa_pcidev_s

PATCH New Rolf Eike Beer 1 participant 2 messages Oct 31, 2012

Subsystems (2)
SCSI Brocade BFA FC SCSI driver
lore
Share & tools
lore

Rolf Eike Beer

author
#0 lore raw

PATCH 1/2 bfa: remove unused pci_slot from struct bfa_pcidev_s

Signed-off-by Rolf Eike Beer <[email protected]>
---
 drivers/scsi/bfa/bfa_ioc.h | 1 -
 drivers/scsi/bfa/bfad.c    | 1 -
 2 files changed, 2 deletions(-)
drivers/scsi/bfa/bfa_ioc.h +0 -1
index b2856f9..80a2c15 100644
@@ -150,7 +150,6 @@ struct bfa_meminfo_s {
  * PCI device information required by IOC
  */
 struct bfa_pcidev_s {
-	int		pci_slot;
 	u8		pci_func;
 	u16		device_id;
 	u16		ssid;
drivers/scsi/bfa/bfad.c +0 -1
index c374949..2543fc3 100644
@@ -750,7 +750,6 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad)
 		goto out_release_region;
 	}
 
-	bfad->hal_pcidev.pci_slot = PCI_SLOT(pdev->devfn);
 	bfad->hal_pcidev.pci_func = PCI_FUNC(pdev->devfn);
 	bfad->hal_pcidev.pci_bar_kva = bfad->pci_bar0_kva;
 	bfad->hal_pcidev.device_id = pdev->device;
Signature · 1 line
1.7.7
author
#1 lore raw

PATCH 2/2 bfa: remove unused bfa_get_pciids() and struct bfa_pciid_s

Signed-off-by Rolf Eike Beer <[email protected]>
---
 drivers/scsi/bfa/bfa.h      |  9 ---------
 drivers/scsi/bfa/bfa_core.c | 18 ------------------
 2 files changed, 27 deletions(-)
drivers/scsi/bfa/bfa.h +0 -9
index 4ad7e36..0ef77dc 100644
@@ -147,14 +147,6 @@ bfa_reqq_winit(struct bfa_reqq_wait_s *wqe, void (*qresume) (void *cbarg),
 	} while (0)
 
 
-/*
- * PCI devices supported by the current BFA
- */
-struct bfa_pciid_s {
-	u16	device_id;
-	u16	vendor_id;
-};
-
 extern char     bfa_version[];
 
 struct bfa_iocfc_regs_s {

@@ -398,7 +390,6 @@ int bfa_iocfc_get_pbc_vports(struct bfa_s *bfa,
 	(((&(_bfa)->modules.dconf_mod)->min_cfg)		\
 	 ? BFA_LUNMASK_MINCFG : ((bfa_get_lun_mask(_bfa))->status))
 
-void bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids);
 void bfa_cfg_get_default(struct bfa_iocfc_cfg_s *cfg);
 void bfa_cfg_get_min(struct bfa_iocfc_cfg_s *cfg);
 void bfa_cfg_get_meminfo(struct bfa_iocfc_cfg_s *cfg,
drivers/scsi/bfa/bfa_core.c +0 -18
index b7c326f..c3f3b25 100644
@@ -1856,24 +1856,6 @@ bfa_comp_free(struct bfa_s *bfa, struct list_head *comp_q)
 }
 
 /*
- * Return the list of PCI vendor/device id lists supported by this
- * BFA instance.
- */
-void
-bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids)
-{
-	static struct bfa_pciid_s __pciids[] = {
-		{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G2P},
-		{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G1P},
-		{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT},
-		{BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT_FC},
-	};
-
-	*npciids = sizeof(__pciids) / sizeof(__pciids[0]);
-	*pciids = __pciids;
-}
-
-/*
  * Use this function query the default struct bfa_iocfc_cfg_s value (compiled
  * into BFA layer). The OS driver can then turn back and overwrite entries that
  * have been configured by the user.
Signature · 1 line
1.7.7