Skip to contentSkip to conversation

Char: mxser_new, don't check tty_unregister retval

PATCH New Jiri Slaby 1 participant 1 message Oct 6, 2006

Subsystems (2)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 4/6 Char: mxser_new, don't check tty_unregister retval

mxser_new, don't check tty_unregister retval

Like other drivers silently unregister_tty_driver and put_tty_driver. It shouldn't be busy when module release function is called, since we are not bsd, no refs shouldn't be held.

---
commit 24213aff7a051554d9e489db5d60605e1a6ae7ab
tree b1bad2212060583b3bf4322e64bf6cf18a6c7cf2
parent 39c9825cc56a093e7779780e2928cf8944cb1148
author Jiri Slaby <[email protected]> Sat, 07 Oct 2006 00:11:04 +0200 committer Jiri Slaby <[email protected]> Sat, 07 Oct 2006 00:11:04 +0200

 drivers/char/mxser_new.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
drivers/char/mxser_new.c +3 -6
index 073926e..25c5091 100644
@@ -2994,15 +2994,12 @@ static int __init mxser_module_init(void
 
 static void __exit mxser_module_exit(void)
 {
-	int i, err;
+	unsigned int i;
 
 	pr_debug("Unloading module mxser ...\n");
 
-	err = tty_unregister_driver(mxvar_sdriver);
-	if (!err)
-		put_tty_driver(mxvar_sdriver);
-	else
-		printk(KERN_ERR "Couldn't unregister MOXA Smartio/Industio family serial driver\n");
+	tty_unregister_driver(mxvar_sdriver);
+	put_tty_driver(mxvar_sdriver);
 
 	for (i = 0; i < MXSER_BOARDS; i++)
 		if (mxser_boards[i].board_type != -1)