Skip to contentSkip to conversation

io_uring: recycle provided buffer if we punt to io-wq

PATCH New Jens Axboe 1 participant 1 message Jun 17, 2022

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: recycle provided buffer if we punt to io-wq

io_arm_poll_handler() will recycle the buffer appropriately if we end up arming poll (or if we're ready to retry), but not for the io-wq case if we have attempted poll first.

Explicitly recycle the buffer to avoid both hanging on to it too long, but also to avoid multiple reads grabbing the same one. This can happen for ring mapped buffers, since it hasn't necessarily been committed.

Fixes c7fb19428d67 ("io_uring: add support for ring mapped supplied buffers")

---

fs/io_uring.c +1 -0
index 95a1a78d799a..d3ee4fc532fa 100644
@@ -8690,6 +8690,7 @@ static void io_queue_async(struct io_kiocb *req, int ret)
 		 * Queued up for async execution, worker will release
 		 * submit reference when the iocb is actually submitted.
 		 */
+		io_kbuf_recycle(req, 0);
 		io_queue_iowq(req, NULL);
 		break;
 	case IO_APOLL_OK:
Signature · 1 line
Jens Axboe