usb-next tree has patch applied twice
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
* 03e607cbb2931374db1825f371e9c7f28526d3f4
* 75fd6485cccef269ac9eb3b71cf56753341195ef
causing my board imx8mm-tqma8mqml-mba8mx.dts failing to probe USB phy:
[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1
Reverting/removing the patch fix my problem.
Thanks
Alexander
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/log/drivers/usb/phy?h=usb-next
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
Greg Kroah-Hartman
maintainerQuoted 5 lines · Alexander Stein
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4
This is from the 5.18 release, from this email series:
https://lore.kernel.org/all/[email protected]/
from 2022.
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195ef
This is from a newer series:
https://lore.kernel.org/all/[email protected]/
that I applied from there.
So how did it apply cleanly twice?
Quoted 5 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1Reverting/removing the patch fix my problem.
Which patch? All of the ones in that last series? If so, why did it apply at all?
totally confused,
greg k-h
Hi,
CC'ing Sean as well.
Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
Quoted 11 lines · Alexander Stein
Quoted 5 lines
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4This is from the 5.18 release, from this email series:
https://lore.kernel.org/all/[email protected]/from 2022.
Quoted 7 lines
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195efThis is from a newer series:
https://lore.kernel.org/all/[email protected]/that I applied from there.
So how did it apply cleanly twice?
Apparently the series from 2024 is v3 from the older v2 one. For some reason only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the apply went unnoticed but the patch is again part of the series :(
Quoted 8 lines
Quoted 5 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1Reverting/removing the patch fix my problem.
Which patch? All of the ones in that last series? If so, why did it apply at all?
In my case I reverted 75fd6485cccef269ac9eb3b71cf56753341195ef from usb-next, because that very change has been applied with 03e607cbb2931374db1825f371e9c7f28526d3f4 already.
Best regards,
Alexander
Quoted 4 lines
totally confused,
greg k-h
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
Greg Kroah-Hartman
maintainerQuoted 32 lines · Alexander Stein
Hi,
CC'ing Sean as well.
Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
Quoted 11 lines · Alexander Stein
Quoted 5 lines
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4This is from the 5.18 release, from this email series:
https://lore.kernel.org/all/[email protected]/from 2022.
Quoted 7 lines
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195efThis is from a newer series:
https://lore.kernel.org/all/[email protected]/that I applied from there.
So how did it apply cleanly twice?
Apparently the series from 2024 is v3 from the older v2 one. For some reason only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the apply went unnoticed but the patch is again part of the series :(
Quoted 4 lines
Quoted 4 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Reverting/removing the patch fix my problem.
Which patch? All of the ones in that last series? If so, why did it apply at all?
In my case I reverted
75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next, because that very change has been applied with03e607cbb2931374db1825f371e9c7f28526d3f4already.
Can you send a patch that resolves this all properly?
thanks,
greg k-h
Am Donnerstag, 22. Februar 2024, 14:06:12 CET schrieb Greg Kroah-Hartman:
Quoted 35 lines · Alexander Stein
Quoted 34 lines
Hi,
CC'ing Sean as well.
Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
Quoted 11 lines · Alexander Stein
Quoted 5 lines
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4This is from the 5.18 release, from this email series:
https://lore.kernel.org/all/[email protected]/from 2022.
Quoted 7 lines
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195efThis is from a newer series:
https://lore.kernel.org/all/[email protected]/that I applied from there.
So how did it apply cleanly twice?
Apparently the series from 2024 is v3 from the older v2 one. For some reason only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the apply went unnoticed but the patch is again part of the series :(
Quoted 6 lines
Quoted 5 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1Reverting/removing the patch fix my problem.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Which patch? All of the ones in that last series? If so, why did it apply at all?
In my case I reverted
75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next, because that very change has been applied with03e607cbb2931374db1825f371e9c7f28526d3f4already.Can you send a patch that resolves this all properly?
Which tree shall this patch apply to? usb-next?
Shall it revert 03e607cbb2931374db1825f371e9c7f28526d3f4 from v5.18 or 75fd6485cccef269ac9eb3b71cf56753341195ef from usb-next?
Thanks,
Alexander
Quoted 4 lines
thanks,
greg k-h
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
Greg Kroah-Hartman
maintainerQuoted 39 lines · Alexander Stein
Am Donnerstag, 22. Februar 2024, 14:06:12 CET schrieb Greg Kroah-Hartman:
Quoted 38 lines · Alexander Stein
Quoted 37 lines
Hi,
CC'ing Sean as well.
Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
Quoted 11 lines · Alexander Stein
Quoted 5 lines
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4This is from the 5.18 release, from this email series:
https://lore.kernel.org/all/[email protected]/from 2022.
Quoted 7 lines
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195efThis is from a newer series:
https://lore.kernel.org/all/[email protected]/that I applied from there.
So how did it apply cleanly twice?
Apparently the series from 2024 is v3 from the older v2 one. For some reason only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the apply went unnoticed but the patch is again part of the series :(
Quoted 8 lines
Quoted 5 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1Reverting/removing the patch fix my problem.
Which patch? All of the ones in that last series? If so, why did it apply at all?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
In my case I reverted
75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next, because that very change has been applied with03e607cbb2931374db1825f371e9c7f28526d3f4already.Can you send a patch that resolves this all properly?
Which tree shall this patch apply to? usb-next?
Yes.
Quoted 2 lines
Shall it revert
03e607cbb2931374db1825f371e9c7f28526d3f4from v5.18 or75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next?
the "unique to usb-next" one please.
Also realize that there was multiple patches in that series that were applied, can you check the others as well?
thanks,
greg k-h
Quoted 50 lines · Greg Kroah-Hartman
Quoted 39 lines · Alexander Stein
Am Donnerstag, 22. Februar 2024, 14:06:12 CET schrieb Greg Kroah-Hartman:
Quoted 38 lines · Alexander Stein
Quoted 37 lines
Hi,
CC'ing Sean as well.
Am Donnerstag, 22. Februar 2024, 08:47:28 CET schrieb Greg Kroah-Hartman:
Quoted 11 lines · Alexander Stein
Quoted 5 lines
Hi Greg,
on the usb-next tree [1] the patch 'usb: phy: generic: Get the vbus supply has been applied twice:
*03e607cbb2931374db1825f371e9c7f28526d3f4This is from the 5.18 release, from this email series:
https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2flore.kernel.org%2fall%2f20220425171412.1188485%2d3%2dsean.anderson%40seco.com%2f&umid=65610ef7-cec9-4349-9da2-5479da31f7a6&auth=d807158c60b7d2502abde8a2fc01f40662980862-b44e4424759ff89719033b8aec4852f55b694453from 2022.
Quoted 7 lines
Quoted 1 line
*
75fd6485cccef269ac9eb3b71cf56753341195efThis is from a newer series:
https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2flore.kernel.org%2fall%2f20240123225111.1629405%2d3%2dsean.anderson%40seco.com%2f&umid=65610ef7-cec9-4349-9da2-5479da31f7a6&auth=d807158c60b7d2502abde8a2fc01f40662980862-bd5a1c24e9d7496c10f251fb9eff5b0c1af1baefthat I applied from there.
So how did it apply cleanly twice?
Apparently the series from 2024 is v3 from the older v2 one. For some reason only patch 2/4 from v2 got applied before. v3 seems to be a rebase where the apply went unnoticed but the patch is again part of the series :(
Quoted 8 lines
Quoted 5 lines
causing my board
imx8mm-tqma8mqml-mba8mx.dtsfailing to probe USB phy:[ 11.006720] usb_phy_generic usbphynop1: error -EPERM: could not get vbus regulator [ 11.017817] usb_phy_generic: probe of usbphynop1 failed with error -1Reverting/removing the patch fix my problem.
Which patch? All of the ones in that last series? If so, why did it apply at all?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
In my case I reverted
75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next, because that very change has been applied with03e607cbb2931374db1825f371e9c7f28526d3f4already.Can you send a patch that resolves this all properly?
Which tree shall this patch apply to? usb-next?
Yes.
Quoted 7 lines
Quoted 2 lines
Shall it revert
03e607cbb2931374db1825f371e9c7f28526d3f4from v5.18 or75fd6485cccef269ac9eb3b71cf56753341195effrom usb-next?the "unique to usb-next" one please.
Also realize that there was multiple patches in that series that were applied, can you check the others as well?
That should be the only one.
I replied to the original patch [1], but I guess I should have also replied to [2] ?
--Sean
[1] https://lore.kernel.org/all/[email protected]/
[2] message id 2024012811-rounding-foam-3366@gregkh (not on lists)
[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>