Skip to contentSkip to conversation

bio_vec, bv_page and folios

DISCUSSION David Howells 2 participants 4 messages Jan 2, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Christoph, Willy,

Will bv_page in struct bio_vec ever become a folio pointer rather than I page pointer? I'm guessing not as it still presumably needs to be able to point to non-folio pages.

David

#1 lore raw
Quoted 5 lines · David Howells

Hi Christoph, Willy,

Will bv_page in struct bio_vec ever become a folio pointer rather than I page pointer? I'm guessing not as it still presumably needs to be able to point to non-folio pages.

My plan for bio_vec is that it becomes phyr -- a physical address + length. No more page or folio reference.

#2 lore raw
Quoted 9 lines · Matthew Wilcox
Quoted 5 lines · David Howells

Hi Christoph, Willy,

Will bv_page in struct bio_vec ever become a folio pointer rather than I page pointer? I'm guessing not as it still presumably needs to be able to point to non-folio pages.

My plan for bio_vec is that it becomes phyr -- a physical address + length. No more page or folio reference.

Interesting... What does that mean for those places that currently use bv_page as a place to stash a pointer to the page and use it to clean up the page later?

David

#3 lore raw
Quoted 9 lines · David Howells
Quoted 7 lines · Matthew Wilcox
Quoted 5 lines · David Howells

Hi Christoph, Willy,

Will bv_page in struct bio_vec ever become a folio pointer rather than I page pointer? I'm guessing not as it still presumably needs to be able to point to non-folio pages.

Quoted 6 lines
Quoted 2 lines

My plan for bio_vec is that it becomes phyr -- a physical address + length. No more page or folio reference.

Interesting... What does that mean for those places that currently use bv_page as a place to stash a pointer to the page and use it to clean up the page later?

I don't intend to get rid of bio_for_each_folio_all() or bio_add_page() for example. It's just a phys_to_page() away. The advantage is that we wouldn't need a struct page to do I/O to a physical address.