Skip to contentSkip to conversation

time: Change log level of "NOHZ: local_softirq_pending" message

PATCH New Rado Vrbovsky 2 participants 2 messages Feb 8, 2013 – Mar 25, 2013 1 message not in the archive Nohz, dynticks support

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 time: Change log level of "NOHZ: local_softirq_pending" message

In reply to a message not in the archive

The "NOHZ: local_softirq_pending" message is a largely informational message. This makes extra work for customers that have a policy of investigating all kernel log messages logged at <= KERN_ERR log level.
This patch sets the message to a different log level.

---
 kernel/time/tick-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/tick-sched.c +1 -1
index d58e552..ece2beb 100644
@@ -481,7 +481,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
                if (ratelimit < 10 &&
                    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-                       printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
+                       printk(KERN_WARNING "NOHZ: local_softirq_pending %02x\n",
                               (unsigned int) local_softirq_pending());
                        ratelimit++;
                }
Signature · 1 line
1.7.11.7
#2 lore raw

[tip:timers/core] tick: Change log level of NOHZ: local_softirq_pending message

tick: Change log level of NOHZ: local_softirq_pending message
Commit-ID:  cfea7d7e452f57682a0bb55a55e9f79c569558c2
Gitweb:     http://git.kernel.org/tip/cfea7d7e452f57682a0bb55a55e9f79c569558c2
Author:     Rado Vrbovsky <[email protected]>
AuthorDate: Fri, 8 Feb 2013 12:37:30 -0500
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Mon, 25 Mar 2013 10:46:59 +0100

tick: Change log level of NOHZ: local_softirq_pending message

The "NOHZ: local_softirq_pending" message is a largely informational message. This makes extra work for customers that have a policy of investigating all kernel log messages logged at <= KERN_ERR log level. This patch sets the message to a different log level.

[ tglx: Use pr_warn() ]

---
 kernel/time/tick-sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/tick-sched.c +2 -2
index a19a399..225f8bf 100644
@@ -482,8 +482,8 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
 		if (ratelimit < 10 &&
 		    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
-			       (unsigned int) local_softirq_pending());
+			pr_warn("NOHZ: local_softirq_pending %02x\n",
+				(unsigned int) local_softirq_pending());
 			ratelimit++;
 		}
 		return false;