Skip to contentSkip to conversation

tsc40: remove wrong announcement of pressure support

PATCH Applied Rolf Eike Beer 2 participants 2 messages Oct 26, 2012 – Oct 31, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tsc40: remove wrong announcement of pressure support

The tsc40 driver announces it supports the pressure event, but will never send one. The announcement will cause tslib to wait for such events and sending all touch events with a pressure of 0. Removing the announcement will make tslib fall back to emulating the pressure on touch events so everything works as expected.

---
 drivers/input/touchscreen/tsc40.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/tsc40.c +0 -1
index 63209aa..eb96f16 100644
@@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
 	__set_bit(BTN_TOUCH, input_dev->keybit);
 	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
 	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
-	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
 
 	serio_set_drvdata(serio, ptsc);
 
Signature · 1 line
1.7.11.5
maintainer Applied
#1 lore raw
Quoted 8 lines · Rolf Eike Beer

The tsc40 driver announces it supports the pressure event, but will never send one. The announcement will cause tslib to wait for such events and sending all touch events with a pressure of 0. Removing the announcement will make tslib fall back to emulating the pressure on touch events so everything works as expected.

Applied, thank you Rolf.

Quoted 24 lines
---
 drivers/input/touchscreen/tsc40.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/tsc40.c +0 -1
index 63209aa..eb96f16 100644
@@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
 	__set_bit(BTN_TOUCH, input_dev->keybit);
 	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
 	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
-	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
 
 	serio_set_drvdata(serio, ptsc);
 
Signature · 7 lines
1.7.11.5


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Dmitry