Skip to contentSkip to conversation

cpufreq: Retrieve current frequency from scaling drivers with internal governors

PATCH In review [email protected] 2 participants 2 messages Feb 1, 2013 – Feb 2, 2013 1 message not in the archive CPU frequency scaling framework

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/6 cpufreq: Retrieve current frequency from scaling drivers with internal governors

From: Dirk Brandewie <[email protected]>

Scaling drivers that implement the cpufreq_driver.setpolicy() versus the cpufreq_driver.target() interface do not set policy->cur.

Normally policy->cur is set during the call to cpufreq_driver.target() when the frequnecy request is made by the governor.

If the scaling driver implements cpufreq_driver.setpolicy() and cpufreq_driver.get() interfaces use cpufreq_driver.get() to retrieve the current frequency.

---
 drivers/cpufreq/cpufreq.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/cpufreq/cpufreq.c +3 -0
index 1f93dbd..1c037f0 100644
@@ -1219,6 +1219,9 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
 	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
 	unsigned int ret_freq = 0;
 
+	if (cpufreq_driver && cpufreq_driver->setpolicy && cpufreq_driver->get)
+		return cpufreq_driver->get(cpu);
+
 	if (policy) {
 		ret_freq = policy->cur;
 		cpufreq_cpu_put(policy);
Signature · 1 line
1.7.7.6
maintainer
#2 lore raw

drivers/cpufreq/cpufreq.c unsigned int cpufreq_quick_get(unsigned int cpu) · line 1223

Quoted 8 lines · On Sat, Feb 2, 2013 at 12:19 AM, <[email protected]> wrote:
drivers/cpufreq/cpufreq.c +2 -0
@@ -1219,6 +1219,9 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
        struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
        unsigned int ret_freq = 0;
 
+       if (cpufreq_driver && cpufreq_driver->setpolicy && cpufreq_driver->get)
+               return cpufreq_driver->get(cpu);

You are required to do cpufreq_cpu_put() in this case too... Better do cpufreq_cpu_get() after your check.

Quoted 11 lines
drivers/cpufreq/cpufreq.c +1 -1
+
        if (policy) {
                ret_freq = policy->cur;
                cpufreq_cpu_put(policy);
--

1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html