Skip to contentSkip to conversation

7/7 Fix error bounds checking for NUMA-Q

PATCH New Martin J. Bligh 1 participant 1 message Feb 28, 2003

lore
Share & tools
lore

Martin J. Bligh

author
#0 lore raw

PATCH 1/1 7/7 Fix error bounds checking for NUMA-Q

Patch from Dave Hansen.

Fix simpile bounding error found by some Stanford-checker type thing to use the proper MAX_MP_BUSSES define instead of a constant.

arch/i386/pci/numa.c +2 -2
diff -urpN -X /home/fletch/.diff.exclude 015-notsc/arch/i386/pci/numa.c 016-numa_pci_fix/arch/i386/pci/numa.c
@@ -17,7 +17,7 @@ static int __pci_conf1_mq_read (int seg,
 {
 	unsigned long flags;
 
-	if (!value || (bus > 255) || (dev > 31) || (fn > 7) || (reg > 255))
+	if (!value || (bus > MAX_MP_BUSSES) || (dev > 31) || (fn > 7) || (reg > 255))
 		return -EINVAL;
 
 	spin_lock_irqsave(&pci_config_lock, flags);

@@ -45,7 +45,7 @@ static int __pci_conf1_mq_write (int seg
 {
 	unsigned long flags;
 
-	if ((bus > 255) || (dev > 31) || (fn > 7) || (reg > 255)) 
+	if ((bus > MAX_MP_BUSSES) || (dev > 31) || (fn > 7) || (reg > 255)) 
 		return -EINVAL;
 
 	spin_lock_irqsave(&pci_config_lock, flags);