Skip to contentSkip to conversation

lapi/syscalls: Add epoll_create for aarch64.in

PATCH zhaogongyi 2 participants 2 messages Oct 27, 2021

lore
Share & tools
lore

zhaogongyi

author
#0 lore raw

Hi,

Quoted 25 lines
Quoted 22 lines · Zhao Gongyi

Add epoll_create for aarch64.in and modify the value of epoll_ctl for aarch64.in. Otherwise, the testcase epoll_create01/epoll_create02 will fail.

---
 include/lapi/syscalls/aarch64.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/lapi/syscalls/aarch64.in +0 -1
index a47185954..e9023a1d0 100644
@@ -19,7 +19,6 @@ getcwd 17
 lookup_dcookie 18
 eventfd2 19
 epoll_create1 20
-epoll_ctl 21
 epoll_pwait 22
 dup 23
Quoted 8 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open 241 · line 245

Quoted 6 lines
include/lapi/syscalls/aarch64.in +2 -0
 dup3 24
@@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240  perf_event_open 241
 accept4 242
 recvmmsg 243
+epoll_create 250
+epoll_ctl 251

These values are for 32 bit only syscalls. Won't this break 64 bit?

Yes, these values are for 32 bit only syscalls, the syscall epoll_create is not support for 64bit arm64.

Reference to man 2 epoll_create, we can see that epoll_create/epoll_create1 are supported If only we include the header file sys/epoll.h.

Is it better that we call epoll_create replace to syscall __NR_epoll_create since some plateform not support it?

Thanks for you review!

Quoted 11 lines
Quoted 11 lines
include/lapi/syscalls/aarch64.in +0 -1
 wait4 260
 prlimit64 261
 fanotify_init 262
--

2.17.1

--
Mailing list info: https://lists.linux.it/listinfo/ltp

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw
Quoted 37 lines · zhaogongyi

Hi,

Quoted 25 lines
Quoted 22 lines · Zhao Gongyi

Add epoll_create for aarch64.in and modify the value of epoll_ctl for aarch64.in. Otherwise, the testcase epoll_create01/epoll_create02 will fail.

---
 include/lapi/syscalls/aarch64.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/lapi/syscalls/aarch64.in +0 -1
index a47185954..e9023a1d0 100644
@@ -19,7 +19,6 @@ getcwd 17
 lookup_dcookie 18
 eventfd2 19
 epoll_create1 20
-epoll_ctl 21
 epoll_pwait 22
 dup 23
Quoted 8 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open 241 · line 245

Quoted 6 lines
include/lapi/syscalls/aarch64.in +2 -0
 dup3 24
@@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240  perf_event_open 241
 accept4 242
 recvmmsg 243
+epoll_create 250
+epoll_ctl 251

These values are for 32 bit only syscalls. Won't this break 64 bit?

Quoted 1 line

Yes, these values are for 32 bit only syscalls, the syscall epoll_create is not support for 64bit arm64.

Right, adding epoll_create is OK, but changing epoll_ctl would break 64bit if there were any users of __NR_epoll_ctl.

Quoted 4 lines

Reference to man 2 epoll_create, we can see that epoll_create/epoll_create1 are supported If only we include the header file sys/epoll.h.

Is it better that we call epoll_create replace to syscall __NR_epoll_create since some plateform not support it?

I think so. We already use epoll_create() in other tests, so this looks like simplest solution for all arches.

Quoted 16 lines

Thanks for you review!

Quoted 11 lines
Quoted 11 lines
include/lapi/syscalls/aarch64.in +0 -1
 wait4 260
 prlimit64 261
 fanotify_init 262
--

2.17.1

--
Mailing list info: https://lists.linux.it/listinfo/ltp

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp