Skip to contentSkip to conversation

arc: drop definitions of pgd_index() and pgd_offset{,_k}() entirely

PATCH In review Rolf Eike Beer 2 participants 2 messages Mar 28, 2022 – Apr 18, 2022 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arc: drop definitions of pgd_index() and pgd_offset{,_k}() entirely

They were in <asm/pgtables.h> and have been removed from there in 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions") in favor of the generic version. But that missed that the same definitons also existed in <asm/pgtable-levels.h>, where they were (inadvertently?) introduced in fe6cb7b043b6 ("ARC: mm: disintegrate pgtable.h into levels and flags").

Fixes 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions")
Fixes fe6cb7b043b6 ("ARC: mm: disintegrate pgtable.h into levels and flags")
---
 arch/arc/include/asm/pgtable-levels.h | 3 ---
 1 file changed, 3 deletions(-)
arch/arc/include/asm/pgtable-levels.h +0 -3
index 7848348719b2..64ca25d199be 100644
@@ -98,9 +98,6 @@
 /*
  * 1st level paging: pgd
  */
-#define pgd_index(addr)		((addr) >> PGDIR_SHIFT)
-#define pgd_offset(mm, addr)	(((mm)->pgd) + pgd_index(addr))
-#define pgd_offset_k(addr)	pgd_offset(&init_mm, addr)
 #define pgd_ERROR(e) \
 	pr_crit("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pgd_val(e))
 
Signature · 11 lines
2.35.1


-- 
Rolf Eike Beer, emlix GmbH, https://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source
maintainer
#1 lore raw

Re: [PATCH] arc: drop definitions of pgd_index() and pgd_offset{, _k}() entirely

Quoted 10 lines · Rolf Eike Beer

They were in <asm/pgtables.h> and have been removed from there in 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions") in favor of the generic version. But that missed that the same definitons also existed in <asm/pgtable-levels.h>, where they were (inadvertently?) introduced in fe6cb7b043b6 ("ARC: mm: disintegrate pgtable.h into levels and flags").

Fixes 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions")
Fixes fe6cb7b043b6 ("ARC: mm: disintegrate pgtable.h into levels and flags")

Indeed I missed the upstream change when doing the rework for paging levels.

Applied !

Thx,
-Vineet

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc