Skip to contentSkip to conversation

pm-acpi-hibernation-utilize-hardware-signature.patch causes build error

mmotm [email protected] 2 participants 2 messages Jul 14, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Patch pm-acpi-hibernation-utilize-hardware-signature.patch in the 07/11 mmotm causes a link error:

LD .tmp_vmlinux1
arch/x86/kernel/built-in.o: In function `acpi_sleep_setup':
sleep.c:(.init.text+0x6854): undefined reference to `acpi_no_s4_hw_signature'

Not at all surprising, since the patch doesn't actually include a body for the function, only references. Did a (hopefully) previous patch that added the body get lost along the way?

#1 lore raw
Quoted 10 lines · On Sun, 2008-07-13 at 04:44 -0400, [email protected] wrote:

Patch pm-acpi-hibernation-utilize-hardware-signature.patch in the 07/11 mmotm causes a link error:

LD .tmp_vmlinux1
arch/x86/kernel/built-in.o: In function `acpi_sleep_setup':
sleep.c:(.init.text+0x6854): undefined reference to `acpi_no_s4_hw_signature'

Not at all surprising, since the patch doesn't actually include a body for the function, only references. Did a (hopefully) previous patch that added the body get lost along the way?

this should fix it.

---
 arch/x86/kernel/acpi/sleep.c |    2 ++
 1 file changed, 2 insertions(+)
arch/x86/kernel/acpi/sleep.c +2 -0
Index: linux-next/arch/x86/kernel/acpi/sleep.c
===================================================================
@@ -140,8 +140,10 @@ static int __init acpi_sleep_setup(char 
 			acpi_realmode_flags |= 2;
 		if (strncmp(str, "s3_beep", 7) == 0)
 			acpi_realmode_flags |= 4;
+#ifdef CONFIG_HIBERNATION
 		if (strncmp(str, "s4_nohwsig", 10) == 0)
 			acpi_no_s4_hw_signature();
+#endif
 		if (strncmp(str, "old_ordering", 12) == 0)
 			acpi_old_suspend_ordering();
 		str = strchr(str, ',');