Skip to contentSkip to conversation

Stupid lockdep question...

DISCUSSION [email protected] 2 participants 2 messages Oct 13, 2010

lore
Share & tools
lore
#0 lore raw

I have a 3rd-party module, that throws this whinge:

[   65.831296] INFO: trying to register non-static key.
[   65.831301] the code is fine but needs lockdep annotation.
[   65.831303] turning off the locking correctness validator.

I've identified that it's a call to down(*foo) where foo points to a kmalloc'ed block of memory that's memset() to all-zeros. What's the initializer/annotation I need to add to my code?

#1 lore raw
Quoted 10 lines · On Wednesday 13 October 2010, [email protected] wrote:

I have a 3rd-party module, that throws this whinge:

[   65.831296] INFO: trying to register non-static key.
[   65.831301] the code is fine but needs lockdep annotation.
[   65.831303] turning off the locking correctness validator.

I've identified that it's a call to down(*foo) where foo points to a kmalloc'ed block of memory that's memset() to all-zeros. What's the initializer/annotation I need to add to my code?

It would be easier if you posted a link to the source, but the best answer is problably:

- replace the semaphore with a regular mutex,
- use mutex_init to initialize it after the allocation.

Arnd