*_find_end_of_memory Mach Dep?
Quoted 10 lines · Charles Lepple
Quoted 4 lines · Grant Erickson
Instead of having a mess of ifdef's and such in
MMU_initfor {apus, pmac, m8xx, oak, chrp, etc}_find_end_of_memory, is there any compelling reason not to make appc_mdmachine dependency entry for these?When I converted some code to the
ppc_mdinterface, I seem to remember a few cases where I couldn't do it that way because theppc_mdstructure was not completely filled out. It can get to be a catch-22 -- there has to be one messy function.
Fair enough. However, since identify_machine is called before MMU_init and <platform>_init is called in identify_machine, then it's reasonable that the ppc_md structure is filled out by the time we hit MMU_init.
So, it seems reasonable that "identify_machine" remains the messy function and MMU_init could be cleaned up somewhat.
Grant
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Quoted 5 lines · Grant Erickson
Quoted 4 lines · Charles Lepple
When I converted some code to the
ppc_mdinterface, I seem to remember a few cases where I couldn't do it that way because theppc_mdstructure was not completely filled out. It can get to be a catch-22 -- there has to be one messy function.
I already checked this before I sent my reply, and it should work fine.
Quoted 2 lines
So, it seems reasonable that "
identify_machine" remains the messy function andMMU_initcould be cleaned up somewhat.
It only looks messy because you haven't seen it grow over the years :-). I think it is aging rather gracefully.....
-- Dan
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/