Skip to contentSkip to conversation

Bug in classzone patch?

DISCUSSION Andrea Arcangeli 1 participant 1 message May 7, 2000 1 message not in the archive Memory management

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andrea Arcangeli

author
#1 lore raw

[ cc'ed to linux-mm to let know people I was wrong about pgdat_list not
null terminated, sorry ]

Quoted 11 lines · Benjamin Redelings I
(quoted diff) +1 -1
-	pgdat->node_next = pgdat_list;
+	pgdat->node_next = NULL;

	pgdat_list = pgdat;

Hi Andrea,
I don't understand this bit of your classzone patch. You say that this
changes makes pgdat_list NULL-terminated.
However, pgdat_list is ALREADY null terminated:

telomere:/usr/src/linux/mm> grep 'pgdat_list' *c page_alloc.c:pg_data_t *pgdat_list = (pg_data_t *)0;

Ah, I see, you're right. Thanks. (btw there's no reason to initialize the pgdat_list to zero since it's global and it could fit in the .bss)

Quoted 1 line

Am I missing something, or is this a bug in your classzone patch?

Yes, it's a bug in the classzone patch that can trigger only in NUMA. I'll fix it thanks.

Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/