Skip to contentSkip to conversation

megaraid_sas: Delete a redundant memory setting in megasas_alloc_cmds()

PATCH New Markus Elfring 1 participant 1 message Jun 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 megaraid_sas: Delete a redundant memory setting in megasas_alloc_cmds()

From: Markus Elfring <[email protected]>
Date: Mon, 17 Jun 2019 12:42:15 +0200

The memory was set to zero already by a call of the function “kcalloc”. Thus remove an extra call of the function “memset” for this purpose.

This issue was detected by using the Coccinelle software.

---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_base.c +0 -2
index 176b59a34a79..047990d3cffd 100644
@@ -4239,8 +4239,6 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
 		return -ENOMEM;
 	}
 
-	memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd);
-
 	for (i = 0; i < max_cmd; i++) {
 		instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd),
 						GFP_KERNEL);

--
2.22.0