Skip to contentSkip to conversation

[09051_47] Siano: smsdvb - add DVB v3 events

PATCH Uri Shkolnik 2 participants 2 messages May 19, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw
Quoted 134 lines · Michael Krufky

From: Michael Krufky <[email protected]>
Subject: Re: [PATCH] [09051_47] Siano: smsdvb - add DVB v3 events
To: "Uri Shkolnik" <[email protected]>
Cc: "LinuxML" <[email protected]>, "Mauro Carvalho Chehab" <[email protected]>
Date: Tuesday, May 19, 2009, 7:18 PM

Quoted 10 lines · Uri Shkolnik

# HG changeset patch
# User Uri Shkolnik <[email protected]>
# Date 1242747164 -10800
# Node ID 971d4cc0d4009650bd4752c6a9fc09755ef77baf # Parent  98895daafb42f8b0757fd608b29c53c80327520e [09051_47] Siano: smsdvb - add DVB v3 events

From: Uri Shkolnik <[email protected]>

Quoted 8 lines

Add various DVB-API v3 events, those events will trig target (card) events.

Priority: normal

diff -r 98895daafb42 -r 971d4cc0d400

linux/drivers/media/dvb/siano/smsdvb.c

Quoted 1 line

--- a/linux/drivers/media/dvb/siano/smsdvb.c    Tue

May 19 18:27:38 2009 +0300
Quoted 1 line

+++ b/linux/drivers/media/dvb/siano/smsdvb.c    Tue

May 19 18:32:44 2009 +0300

Review MODULE_PARM_DESC(debug, "set debug

Quoted 1 line
(quoted diff) +0 -0
@@ -66,6 +66,54 @@ MODULE_PARM_DESC(debug, "set debug

level

Quoted 2 lines
(quoted diff) +0 -0
  /* Events that may come from DVB v3 adapter */

 static void sms_board_dvb3_event(struct

smsdvb_client_t *client,

Quoted 3 lines

               enum SMS_DVB3_EVENTS event) {
+
+       struct smscore_device_t *coredev =

client->coredev;

Quoted 4 lines

+       switch (event) {
+       case DVB3_EVENT_INIT:
+               sms_debug("DVB3_EVENT_INIT");
+               sms_board_event(coredev,

BOARD_EVENT_BIND);

Quoted 4 lines

+               break;
+       case DVB3_EVENT_SLEEP:
+               sms_debug("DVB3_EVENT_SLEEP");
+               sms_board_event(coredev,

BOARD_EVENT_POWER_SUSPEND);

Quoted 3 lines

+               break;
+       case DVB3_EVENT_HOTPLUG:
+

sms_debug("DVB3_EVENT_HOTPLUG");

Quoted 1 line

+               sms_board_event(coredev,

BOARD_EVENT_POWER_INIT);

Quoted 3 lines

+               break;
+       case DVB3_EVENT_FE_LOCK:
+               if (client->event_fe_state

!= DVB3_EVENT_FE_LOCK) {

Quoted 1 line

+

client->event_fe_state = DVB3_EVENT_FE_LOCK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_FE_LOCK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_FE_LOCK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_FE_UNLOCK:
+               if (client->event_fe_state

!= DVB3_EVENT_FE_UNLOCK) {

Quoted 1 line

+

client->event_fe_state = DVB3_EVENT_FE_UNLOCK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_FE_UNLOCK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_UNC_OK:
+               if (client->event_unc_state

!= DVB3_EVENT_UNC_OK) {

Quoted 1 line

+

client->event_unc_state = DVB3_EVENT_UNC_OK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_UNC_OK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_UNC_ERR:
+               if (client->event_unc_state

!= DVB3_EVENT_UNC_ERR) {

Quoted 1 line

+

client->event_unc_state = DVB3_EVENT_UNC_ERR;

Quoted 1 line

+

sms_debug("DVB3_EVENT_UNC_ERR");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS);

Quoted 5 lines

+               }
+               break;
+
+       default:
+               sms_err("Unknown dvb3 api

event");

Quoted 5 lines

+               break;
+       }
 }

 static int smsdvb_onresponse(void *context, struct

smscore_buffer_t *cb)

Quoted 6 lines

--
To unsubscribe from this list: send the line

"unsubscribe linux-media" in

Quoted 3 lines

the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Uri,

I don't understand what prompts you to call these "DVB v3 events" ...
what does this have to do with DVB API v3 at all? Your idea seems to
be in the right direction, but this "DVBV3" nomenclature is a total
misnomer.

Quoted 7 lines

I think something along the lines of SMSBOARD_EVENT_FOO is more appropriate.

Regards,

Mike

Mike,

Within the DVB version 3 adapter, there is events manager, and the name we put on it is "dvb3_event", I think its OK....

Uri

#1 lore raw
Quoted 151 lines · Uri Shkolnik
Quoted 134 lines · Michael Krufky

From: Michael Krufky <[email protected]>
Subject: Re: [PATCH] [09051_47] Siano: smsdvb - add DVB v3 events
To: "Uri Shkolnik" <[email protected]>
Cc: "LinuxML" <[email protected]>, "Mauro Carvalho Chehab" <[email protected]>
Date: Tuesday, May 19, 2009, 7:18 PM

Quoted 10 lines · Uri Shkolnik

# HG changeset patch
# User Uri Shkolnik <[email protected]>
# Date 1242747164 -10800
# Node ID 971d4cc0d4009650bd4752c6a9fc09755ef77baf # Parent  98895daafb42f8b0757fd608b29c53c80327520e [09051_47] Siano: smsdvb - add DVB v3 events

From: Uri Shkolnik <[email protected]>

Quoted 8 lines

Add various DVB-API v3 events, those events will trig target (card) events.

Priority: normal

diff -r 98895daafb42 -r 971d4cc0d400

linux/drivers/media/dvb/siano/smsdvb.c

Quoted 1 line

--- a/linux/drivers/media/dvb/siano/smsdvb.c    Tue

May 19 18:27:38 2009 +0300
Quoted 1 line

+++ b/linux/drivers/media/dvb/siano/smsdvb.c    Tue

May 19 18:32:44 2009 +0300

Review MODULE_PARM_DESC(debug, "set debug

Quoted 1 line
(quoted diff) +0 -0
@@ -66,6 +66,54 @@ MODULE_PARM_DESC(debug, "set debug

level

Quoted 2 lines
(quoted diff) +0 -0
  /* Events that may come from DVB v3 adapter */

 static void sms_board_dvb3_event(struct

smsdvb_client_t *client,

Quoted 3 lines

               enum SMS_DVB3_EVENTS event) {
+
+       struct smscore_device_t *coredev =

client->coredev;

Quoted 4 lines

+       switch (event) {
+       case DVB3_EVENT_INIT:
+               sms_debug("DVB3_EVENT_INIT");
+               sms_board_event(coredev,

BOARD_EVENT_BIND);

Quoted 4 lines

+               break;
+       case DVB3_EVENT_SLEEP:
+               sms_debug("DVB3_EVENT_SLEEP");
+               sms_board_event(coredev,

BOARD_EVENT_POWER_SUSPEND);

Quoted 3 lines

+               break;
+       case DVB3_EVENT_HOTPLUG:
+

sms_debug("DVB3_EVENT_HOTPLUG");

Quoted 1 line

+               sms_board_event(coredev,

BOARD_EVENT_POWER_INIT);

Quoted 3 lines

+               break;
+       case DVB3_EVENT_FE_LOCK:
+               if (client->event_fe_state

!= DVB3_EVENT_FE_LOCK) {

Quoted 1 line

+

client->event_fe_state = DVB3_EVENT_FE_LOCK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_FE_LOCK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_FE_LOCK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_FE_UNLOCK:
+               if (client->event_fe_state

!= DVB3_EVENT_FE_UNLOCK) {

Quoted 1 line

+

client->event_fe_state = DVB3_EVENT_FE_UNLOCK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_FE_UNLOCK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_UNC_OK:
+               if (client->event_unc_state

!= DVB3_EVENT_UNC_OK) {

Quoted 1 line

+

client->event_unc_state = DVB3_EVENT_UNC_OK;

Quoted 1 line

+

sms_debug("DVB3_EVENT_UNC_OK");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK);

Quoted 4 lines

+               }
+               break;
+       case DVB3_EVENT_UNC_ERR:
+               if (client->event_unc_state

!= DVB3_EVENT_UNC_ERR) {

Quoted 1 line

+

client->event_unc_state = DVB3_EVENT_UNC_ERR;

Quoted 1 line

+

sms_debug("DVB3_EVENT_UNC_ERR");

Quoted 1 line

+

sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS);

Quoted 5 lines

+               }
+               break;
+
+       default:
+               sms_err("Unknown dvb3 api

event");

Quoted 5 lines

+               break;
+       }
 }

 static int smsdvb_onresponse(void *context, struct

smscore_buffer_t *cb)

Quoted 6 lines

--
To unsubscribe from this list: send the line

"unsubscribe linux-media" in

Quoted 3 lines

the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Uri,

I don't understand what prompts you to call these "DVB v3 events" ...
what does this have to do with DVB API v3 at all? Your idea seems to
be in the right direction, but this "DVBV3" nomenclature is a total
misnomer.

Quoted 7 lines

I think something along the lines of SMSBOARD_EVENT_FOO is more appropriate.

Regards,

Mike

Mike,

Within the DVB version 3 adapter, there is events manager, and the name we put on it is  "dvb3_event", I think its OK....

Quoted 9 lines

Uri

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

I disagree. Your naming implies that these structures are on the subsystem level, and they have nothing to do with DVB3 anyway -- these are board related events. "dvb3_event" is a total misnomer.

-Mike