Skip to contentSkip to conversation

Pull request for UEFI sub-system for efi-2021-04-rc1-3

DISCUSSION Heinrich Schuchardt 3 participants 3 messages Jan 23, 2021 – Jan 24, 2021

lore
Share & tools
lore
#0 lore raw

Dear Tom,

this pull request fixes a bunch of the recent Coverity CIDs.

The following changes since commit 184aa6504143b452132e28cd3ebecc7b941cdfa1:

Merge tag 'u-boot-rockchip-20210121' of
https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip (2021-01-21 07:39:47 -0500)

are available in the Git repository at:

https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git
tags/efi-2021-04-rc1-3

for you to fetch changes up to 8d0949b3ed6985377682d7ec260be07ef26ef6d4:

efi_loader: correct EFI_BLOCK_IO_PROTOCOL.Media.LastBlock (2021-01-23
07:56:54 +0100)

Gitlab CI reported no problems:
https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/6005

----------------------------------------------------------------
Pull request for UEFI sub-system for efi-2021-04-rc1-3

Bug fixes for UEFI sub-system:

* correct value of EFI_BLOCK_IO_PROTOCOL.Media.LastBlock
* correct GUID when closing of EFI_LOAD_FILE_PROTOCOL
* error handling in mkeficapsule tool

Bug fixes for FAT file system:

* consistent error handling for flush dir()

----------------------------------------------------------------
AKASHI Takahiro (3):
cmd: efidebug: always check return code from get_variable()
efi_loader: capsule: fix SIZEOF_MISMATCH warning
tools: mkeficapsule: fill reserved members of structure

Heinrich Schuchardt (5):
fs: fat: consistent error handling for flush_dir()
fs: fat: structure for name and extension
efi_loader: fix efi_load_image_from_path()
efi_loader: notification with TPL_APPLICATION not allowed
efi_loader: correct EFI_BLOCK_IO_PROTOCOL.Media.LastBlock

Sughosh Ganu (1):
mkeficapsule: Miscellaneous fixes in the utility

  cmd/efidebug.c                | 12 ++++---
  fs/fat/fat.c                  | 32 +++++++++---------
  fs/fat/fat_write.c            | 78
++++++++++++++++++++++---------------------
  include/fat.h                 |  7 +++-
  lib/efi_loader/efi_boottime.c | 14 +++++---
  lib/efi_loader/efi_capsule.c  |  2 +-
  lib/efi_loader/efi_disk.c     | 30 ++++++++++++-----
  tools/mkeficapsule.c          | 41 ++++++++++++++---------
  8 files changed, 126 insertions(+), 90 deletions(-)
#1 lore raw
Quoted 2 lines · Heinrich Schuchardt

efi_loader: correct EFI_BLOCK_IO_PROTOCOL.Media.LastBlock (2021-01-23 07:56:54 +0100)

Confirming that these corrections fix the presented block devices by u-boot EFI to EFI binaries:

Before:
(nonsensical "last block" which is start + length)
Welcome to the Haiku boot loader!
platform_add_boot_device: called
platform_add_boot_device: .. present: true, logical: false, removeable: false, blocksize: 512, lastblock: 681984
platform_add_boot_device: .. present: true, logical: true, removeable: false, blocksize: 512, lastblock: 679936
platform_add_boot_device: .. present: true, logical: true, removeable: false, blocksize: 512, lastblock: 614400

After:
(correct "last block" which is start + length)
Welcome to the Haiku boot loader!
platform_add_boot_device: called
platform_add_boot_device: .. present: true, logical: false, removeable: false, blocksize: 512, lastblock: 681983
platform_add_boot_device: .. present: true, logical: true, removeable: false, blocksize: 512, lastblock: 65535
platform_add_boot_device: .. present: true, logical: true, removeable: false, blocksize: 512, lastblock: 614399

-- Alex

#2 lore raw
In reply to Heinrich Schuchardt
Quoted 15 lines · Heinrich Schuchardt

Dear Tom,

this pull request fixes a bunch of the recent Coverity CIDs.

The following changes since commit 184aa6504143b452132e28cd3ebecc7b941cdfa1:

Merge tag 'u-boot-rockchip-20210121' of
https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip (2021-01-21 07:39:47 -0500)

are available in the Git repository at:

https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git
tags/efi-2021-04-rc1-3

Quoted 8 lines

for you to fetch changes up to 8d0949b3ed6985377682d7ec260be07ef26ef6d4:

efi_loader: correct EFI_BLOCK_IO_PROTOCOL.Media.LastBlock (2021-01-23
07:56:54 +0100)

Gitlab CI reported no problems:
https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/6005

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210124/563d69e1/attachment.sig>