Skip to contentSkip to conversation

2.4.1 -- Unresolved symbols in radio-miropcm20.o

DISCUSSION Miles Lane 6 participants 12 messages Jan 30, 2001 – Feb 1, 2001

lore
Share & tools
lore

Miles Lane

author
#0 lore raw

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o
depmod: aci_write_cmd
depmod: aci_indexed_cmd
depmod: aci_write_cmd_d
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 5 lines · Miles Lane

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o
depmod: aci_write_cmd
depmod: aci_indexed_cmd
depmod: aci_write_cmd_d

Those symbols are defined in drivers/sound/aci.c but are not exported for other modules to use. The aci and miropcm20 code needs to be changed to support use as modules. Also the config.in files need fixing for these files, it is possible to select combinations of aci and miropcm20 that will fail to link (miropcm20 built in, aci not selected or selected as a module) or fail to load (miropcm20 selected as a module, aci not selected).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

author
#2 lore raw

Thanks Keith,

I don't get any errors if I add these lines to my .config file:

CONFIG_SOUND_OSS=m
CONFIG_SOUND_ACI_MIXER=m

Ruurd, are you maintaining this driver?
If not, is anyone else willing to hack the config scripts to enforce this dependency? This is not my area of competency.

Thanks,
Miles

Quoted 17 lines · Keith Owens
Quoted 5 lines · Miles Lane

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o

depmod:        aci_write_cmd
depmod:        aci_indexed_cmd
depmod:        aci_write_cmd_d

Those symbols are defined in drivers/sound/aci.c but are not exported for other modules to use. The aci and miropcm20 code needs to be changed to support use as modules. Also the config.in files need fixing for these files, it is possible to select combinations of aci and miropcm20 that will fail to link (miropcm20 built in, aci not selected or selected as a module) or fail to load (miropcm20 selected as a module, aci not selected).

Quoted 4 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#6 lore raw
In reply to Miles Lane
Quoted 5 lines · In article <[email protected]> you wrote:

Also the config.in files need
fixing for these files, it is possible to select combinations of aci and miropcm20 that will fail to link (miropcm20 built in, aci not selected or selected as a module) or fail to load (miropcm20 selected as a module, aci not selected).

Unfortionatly, this is impossible. The miropcm config question is asked before the "sound" question, and the aci question is asked after that (all in ake config). In 2.2.x we have an #ifdef in the driver that causes an #error with a description of the problem and the solution. Someone stripped that #ifdef out of the driver during 2.3.something.

Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#7 lore raw
Quoted 5 lines · On Wed, 31 Jan 2001 09:46:19 +0100 (CET), [email protected] (Arjan van de…

Unfortionatly, this is impossible. The miropcm config question is asked before the "sound" question, and the aci question is asked after that (all in ake config). In 2.2.x we have an #ifdef in the driver that causes an #error with a description of the problem and the solution. Someone stripped that #ifdef out of the driver during 2.3.something.

I thought the config problem was too hard for the current config language. Oh well, just have to wait until CML2 is part of the kernel, sometime in 2.5.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#8 lore raw
In reply to Miles Lane

[Arjan van de Ven]

Quoted 3 lines

Unfortionatly, this is impossible. The miropcm config question is asked before the "sound" question, and the aci question is asked after that (all in ake config).

"Impossible" is perhaps a poor choice of terms. "Awkward" and "ugly" are, however, quite descriptive. (:

Peter

drivers/sound/Config.in renamed from drivers/sound/Config.in~ +10 -1
diff -urk~ 2.4.1/drivers/sound/Config.in
@@ -91,7 +91,7 @@
    fi
    dep_tristate '    Aztech Sound Galaxy (non-PnP) cards' CONFIG_SOUND_SGALAXY $CONFIG_SOUND_OSS
    dep_tristate '    Adlib Cards' CONFIG_SOUND_ADLIB $CONFIG_SOUND_OSS
-   dep_tristate '    ACI mixer (miroPCM12)' CONFIG_SOUND_ACI_MIXER $CONFIG_SOUND_OSS
+   dep_tristate '    ACI mixer (miroPCM12)' CONFIG_SOUND_WANT_ACI_MIXER $CONFIG_SOUND_OSS
    dep_tristate '    Crystal CS4232 based (PnP) cards' CONFIG_SOUND_CS4232 $CONFIG_SOUND_OSS
    dep_tristate '    Ensoniq SoundScape support' CONFIG_SOUND_SSCAPE $CONFIG_SOUND_OSS
    dep_tristate '    Gravis Ultrasound support' CONFIG_SOUND_GUS $CONFIG_SOUND_OSS
@@ -179,3 +179,12 @@
 fi
 
 dep_tristate '  TV card (bt848) mixer support' CONFIG_SOUND_TVMIXER $CONFIG_SOUND $CONFIG_I2C
+
+# hack, hack
+if [ "$CONFIG_SOUND_WANT_ACI_MIXER" = "y" -o "$CONFIG_RADIO_MIROPCM20" = "y" ]; then
+   define_tristate CONFIG_SOUND_ACI_MIXER y
+else
+   if [ "$CONFIG_SOUND_WANT_ACI_MIXER" = "m" -o "$CONFIG_RADIO_MIROPCM20" = "m" ]; then
+      define_tristate CONFIG_SOUND_ACI_MIXER m
+   fi
+fi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#9 lore raw
In reply to Miles Lane
Quoted 8 lines · Peter Samuelson

[Arjan van de Ven]

Quoted 3 lines

Unfortionatly, this is impossible. The miropcm config question is asked before the "sound" question, and the aci question is asked after that (all in ake config).

"Impossible" is perhaps a poor choice of terms. "Awkward" and "ugly" are, however, quite descriptive. (:

This doesn't take into account the case where someone says "n" to CONFIG_SOUND.

Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#10 lore raw
In reply to Miles Lane
Quoted 7 lines · Peter Samuelson

[Arjan van de Ven]

Quoted 2 lines

This doesn't take into account the case where someone says "n" to CONFIG_SOUND.

So move the test outside the 'if [ "$CONFIG_SOUND" = "y" ]'. The principle is the same.

That won't work, unless you also want to force the soundlayer on people. Which is unacceptable. period. I've been over this when I added the #ifdef to the 2.2 kernel, and nobody came up with a better idea.
At least using the #ifdef + #error, the user gets a proper notification that his kernel won't work and what he can do about it.

Greetings,
Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#11 lore raw
In reply to Miles Lane

[Arjan van de Ven]

Quoted 2 lines

That won't work, unless you also want to force the soundlayer on people. Which is unacceptable. period.

I didn't say it was pretty, I said it was possible. I, too, like your #ifndef solution better.

I suppose yet another hack would be to put a certain amount of #ifdef and #include hackery into radio-miropcm20.c to suck in aci.c if needed. That would be even worse ... but possible.

Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
In reply to Keith Owens
Quoted 16 lines

-----Original Message-----
From: Keith Owens [mailto:[email protected]]
Sent: dinsdag 30 januari 2001 23:52
To: Miles Lane
Cc: [email protected]; Ruurd Reitsma; Norberto Pellicci
Subject: Re: 2.4.1 -- Unresolved symbols in radio-miropcm20.o

Quoted 5 lines · Miles Lane

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o
depmod: aci_write_cmd
depmod: aci_indexed_cmd
depmod: aci_write_cmd_d

Quoted 3 lines

Those symbols are defined in drivers/sound/aci.c but are not exported for other modules to use. The aci and miropcm20 code needs to be changed to support use as modules. Also the config.in files need

They are being exported, otherwise miropcm20.o won't work, would it? I've just been too lazy to change the Config.in properly. It is however mentioned in the radio-miropcm20 helpfile.

Quoted 5 lines

fixing for these files, it is possible to select combinations of aci and miropcm20 that will fail to link (miropcm20 built in, aci not selected or selected as a module) or fail to load (miropcm20 selected as a module, aci not selected).

appearently Robert Siemer's patch didn't make it to the actual kernel. He did change the config.in and made some changes to aci.c to support his version of the firmware. He'll probably be happy to maintain the driver since I threw out the pmc20 card.

--Ruurd

#4 lore raw

From: "Ruurd A. Reitsma" <[email protected]>

Quoted 11 lines
Quoted 6 lines
Quoted 5 lines · Miles Lane

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o
depmod: aci_write_cmd
depmod: aci_indexed_cmd
depmod: aci_write_cmd_d

appearently Robert Siemer's patch didn't make it to the actual kernel. He did change the config.in and made some changes to aci.c to support his version of the firmware. He'll probably be happy to maintain the driver since I threw out the pcm20 card.

Many thanks, Ruurd, for mailing me, too! - I'm not reading linux-kernel completely and looked only for 'aci' is subjects...

First, I've put up a new patch, so don't use this old one. Please read my post to linux-kernel:
http://boudicca.tux.org/hypermail/linux-kernel/latest/0133.html

Second, the described problem is solved: the functions don't exists anymore... (:

Third, my patch still has the same problem. <-: As noted, try my patch only when aci and radio-pcm20 is selected as module. I will work on this issue.

And I have a request to everyone owning a miroSOUND (or Cardinal Technologies) card:
Please try my patch and send me the version line. Mine looks like:
<ACI 0x07, id 6d/43 "m/C", (PCM20 radio)> at 0x344

The patch has some enhancements over the original; read more in my first post:
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0009.2/0260.html

The plans for the future are a well done support of the RDS functions for the "PCM20 radio" and maybe an ALSA driver. This would help me to support the equalizer in the "PCM20 radio" better.

Thanks,
Robert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw
In reply to Keith Owens
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines · Miles Lane

depmod: *** Unresolved symbols in /lib/modules/2.4.1/kernel/drivers/media/radio/radio-miropcm20.o
depmod: aci_write_cmd
depmod: aci_indexed_cmd
depmod: aci_write_cmd_d

I made up an new patch for 2.4.1. You can find it on
http://www.uni-karlsruhe.de/~Robert.Siemer/Private/

It works when:
a) aci: module miropcm20: module
b) aci: build in miropcm20: module
c) aci: build in miropcm20: build in

Violation to this table is still unchecked...

Arjan, I want to include your #ifdef solution, but was unable to find it in 2.2.18... - And further: why did it remove somebody in 2.3.x?

Also (at least) in the case of c) videodev_init() is called twice. - It does not hurt, but maybe someone can give me a hint why this happens...

Ciao,
Robert

PS: Miles email address ([email protected]) is invalid, isn't it? -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/