PATCH 2.4.4.7: serial PCI fixes and cleanup
The attached patch, against 2.4.4-pre7, cleans up the huge pci_board list in serial.c to remove PCI id information. In the process, it (a) demonstrates more complex new-style PCI probing, and (b) fixes a logical disconnect bug which was causing bug reports. The bug caused by me, when I added hotplugging to the serial driver (merging serial_cb in function, but not literally). The bug causes any PCI board which is listed in the serial.c PCI table, but was not PCI_CLASS_COMMUNICATION_SERIAL or PCI_CLASS_COMMUNICATION_MODEM, to be missed in the PCI probe.
Linus - do not apply just yet. I would prefer this patch go into 2.4.5 not 2.4.4, so that we can have a bit more public testing first. tytso - a quick eyeball would be awesome. Ask away with any questions you have.
Alan - please consider applying to your tree.
Steven - please test, this patch removes the need for your serial.c patch.
Others - all testing is welcome.
Signature · 3 lines
Jeff Garzik | Disbelief, that's why you fail. Building 1024 | MandrakeSoft |
Index: linux_2_4/include/linux/serialP.h
include/linux/serialP.h renamed from include/linux/serialP.h:1.1.1.25 +0 -4
@@ -142,10 +142,6 @@*/ struct pci_dev ;struct pci_board { -unsigned short vendor; -unsigned short device; -unsigned short subvendor; -unsigned short subdevice;int flags;int num_ports;int base_baud;
Index: linux_2_4/drivers/char/serial.c
drivers/char/serial.c renamed from drivers/char/serial.c:1.1.1.45 +510 -397
1,066 lines not on this page · raw message
Just a heads up: works great for me
Quoted 19 lines · Jeff Garzik
The attached patch, against 2.4.4-pre7, cleans up the huge
pci_boardlist inserial.cto remove PCI id information. In the process, it (a) demonstrates more complex new-style PCI probing, and (b) fixes a logical disconnect bug which was causing bug reports. The bug caused by me, when I added hotplugging to the serial driver (mergingserial_cbin function, but not literally). The bug causes any PCI board which is listed in theserial.cPCI table, but was notPCI_CLASS_COMMUNICATION_SERIALorPCI_CLASS_COMMUNICATION_MODEM, to be missed in the PCI probe.Linus - do not apply just yet. I would prefer this patch go into 2.4.5 not 2.4.4, so that we can have a bit more public testing first. tytso - a quick eyeball would be awesome. Ask away with any questions you have.
Alan - please consider applying to your tree.
Steven - please test, this patch removes the need for yourserial.cpatch.Others - all testing is welcome.