Skip to contentSkip to conversation

2.4.13-pre1: sonypi.c compile error

DISCUSSION Sander van Geloven 5 participants 5 messages Oct 15, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines

I won't submit a patch to Linus for now, I'm pretty sure that Alan will take care of this for -pre2.

Stelian.

Hi,

I did a build with the patch-2.4.13-pre2.pz applied but it didn't fixed the problem. Your suggestion to add a line in sonypi.c however did work.

Now I also have the same problem as Eyal Lebedinskynew:

make -C i2o modules
make[2]: Entering directory `/home/src/linux-2.4.12/drivers/i2o' gcc -D__KERNEL__ -I/home/src/linux-2.4.12/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS -include
/home/src/linux-2.4.12/include/linux/modversions.h -DEXPORT_SYMTAB -c
i2o_pci.c
i2o_pci.c: In function `i2o_pci_install':
i2o_pci.c:165: structure has no member named `pdev' make[2]: *** [i2o_pci.o] Error 1
make[2]: Leaving directory `/home/src/linux-2.4.12/drivers/i2o' make[1]: *** [_modsubdir_i2o] Error 2
make[1]: Leaving directory `/home/src/linux-2.4.12/drivers'
make: *** [_mod_drivers] Error 2

Has anyone a suggestion?

Thanks,

Sander

#1 lore raw

"A month of sundays ago Sander van Geloven wrote:"

Quoted 3 lines
Quoted 3 lines

I won't submit a patch to Linus for now, I'm pretty sure that Alan will take care of this for -pre2. Stelian.

As far as I recall, I have pre2 and it showed this error on compiling the sony vaio stuff. I fixed it by adding an extern int declaration for is_sony_vaio_laptop in sonypi.c. It was declared in some nonobvious .c file far elsewhere, uh, ... arch/i386/kernel/dmi_scan.c.

There seemed to be a need for an acl.h somewhere too, but maybe that was my xfs patch.

Peter

#2 lore raw
Quoted 2 lines · Peter T. Breuer

There seemed to be a need for an acl.h somewhere too, but maybe that was my xfs patch.

That was your XFS patch. It's fixed in CVS of XFS but can also be fixed by removing all references to include/acl.h in files that fail to compile.

--> Jijo

--
Federico Sevilla III :: [email protected] Network Administrator :: The Leather Collection, Inc. GnuPG Key: <http://jijo.leathercollection.ph/jijo.gpg>

#3 lore raw
In reply to Sander van Geloven
Quoted 9 lines · Peter T. Breuer

"A month of sundays ago Sander van Geloven wrote:"

Quoted 3 lines
Quoted 3 lines

I won't submit a patch to Linus for now, I'm pretty sure that Alan will take care of this for -pre2. Stelian.

As far as I recall, I have pre2 and it showed this error on compiling the sony vaio stuff. I fixed it by adding an extern int declaration for is_sony_vaio_laptop in sonypi.c. It was declared in some nonobvious .c file far elsewhere, uh, ... arch/i386/kernel/dmi_scan.c.

This time Linus took the changes for dmi_scan.c/sonypi.c etc which includes now asm-i386/system.h, but he didn't take the changes for include/asm/system.h :(

Basically, include/asm-i386/system.h needs to contain:

	extern int is_sony_vaio_laptop;

Alan, could you please fed Linus the exact patch for the next pre version ?

Stelian.

Signature · 4 lines
Stelian Pop <[email protected]>
|---------------- Free Software Engineer -----------------|
| Alcôve - http://www.alcove.com - Tel: +33 1 49 22 68 00 |
|------------- Alcôve, liberating software ---------------|
#4 lore raw
In reply to Sander van Geloven
Quoted 1 line

Now I also have the same problem as Eyal Lebedinskynew:

i2o is broken in Linus tree right now. I've not had time to isolate and test the right patches yet but I'll send the bits on to Linus fairly soon