Skip to contentSkip to conversation

Making diff(1) of linux kernels faster

DISCUSSION Marco C. Mason 1 participant 1 message Oct 18, 2001

lore
Share & tools
lore
#0 lore raw

Paul--

Review

Quoted 5 lines · Paul Gortmaker
(quoted diff) +5 -0
+          if (recursive && preread_dir)
+           {
+              preread(inf[0].name);
+              preread(inf[1].name);
+            }

While looking over your patch, I notice that you preload *both* directories. (At least, that's what the code above appears to do). Have you tried just preloading one? This may still give you the speed benefit (as you'll most likely reduce the seeking) and put less pressure on the memory system.

--marco