Skip to contentSkip to conversation

remove trailing whitespace

PATCH In review Padraig Brady 3 participants 3 messages Nov 23, 2001 – Nov 25, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove trailing whitespace

This (23MB! (5Mb compressed)) patch removes trailing whitespace from all files in the kernel, thereby reducing size from 121,865,495 to 121,640,841. I.E. reducing size by 224,654 bytes. I don't know if it's of any use, but it should be applied now if it is going to be done at all.

http://www.iol.ie/~padraiga/linux-2.5.0-strip-ws.diff.gz

cheers,
Padraig.

#1 lore raw
Quoted 7 lines · Padraig Brady

This (23MB! (5Mb compressed)) patch removes trailing whitespace from all files in the kernel, thereby reducing size from 121,865,495 to 121,640,841. I.E. reducing size by 224,654 bytes. I don't know if it's of any use, but it should be applied now if it is going to be done at all.

http://www.iol.ie/~padraiga/linux-2.5.0-strip-ws.diff.gz

Isn't it easier to write a script 'clean_trailing_ws' (or whatever) and add it to scripts/ ?
Linus can apply such 'cleaning' scripts at times like 2.4 -> 2.5 --
vda

#2 lore raw
In reply to Padraig Brady
Quoted 3 lines · vda

Isn't it easier to write a script 'clean_trailing_ws' (or whatever) and add it to scripts/ ?
Linus can apply such 'cleaning' scripts at times like 2.4 -> 2.5

It's best to have a script that you pass all patches through which strips off trailing space on any line that gets added (you can't do it blindly since the context lines must obviously match the original, as must the lines being removed).

I do this automatically when people send stuff to my patch system. Appears to work well.

It solves the problem of the trailing space getting into the source in the first place, and doesn't produce a huge 25MB patch.

I suppose you could also remove anything which matched 1-7 spaces and a tab character, but this might be less reliable. Obviously you can't replace 8 spaces with a tab character, since it might be part of a printk string.

If anyone's interested, this is a fragment from the perl script which processes incoming patches. Might be useful to someone.

	#
	# And now the actual patch itself
	#
	while (<STDIN>)
	{
		chomp;
		s/\s+$// if m/^\+/;
		$mail .= "$_\n";
		$patchtext .= "$_\n";
	}

I'm sure someone can come up with something more efficient. 8)

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html