Skip to contentSkip to conversation

A slightly smarter dmi_scan.c

PATCH Alvin of Diaspar 1 participant 1 message Dec 26, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

APM can also be compiled as a module.

Right. Thanks. I blatantly ignored that APM can be built as modules ;( The fixed patch is here.

I think I prefer it without all the ifdefs being in the code like that. It is cleaner to read before the change. I agree the messages being printed might be confusing in some cases but I don't like the cure.

I agree. The code in dmi_scan.c runs very elegantly now, and changing
that flow, although might be more efficient by something like 0.001%, isn't worth the touble.
Sorry about adding to the ambient background radiation :)

- ioj

~~~~
Ask not of race, but ask of conduct:
From the stick is born the sacred fire:
The wise ascetic, though lowly born,
Is noble in his modest self-control.
- Gotama Buddha
.