linux 2.5 and ppa.c
Quoted 7 lines · John Weber
This is one of those drivers still broken due to the BIO changes (it still calls
io_request_lock()).Unfortunately, I only know enough to
s/io_request_lock/host->host_lock/g.I am afraid this requires a little more than this.
John,
The ppa_detect() must _not_ take the host_lock semaphore as it is already taken by the mid level before it calls ppa_detect(). [This will cause a lock up on an SMP machine.]
The ppa_interrupt() should take the host_lock semaphore before it calls scsi_done() (which calls up the scsi driver stack).
The imm driver has been built by the same firm (Tim Waugh?) and it looks correctly patched.
Doug Gilbert
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Douglas Gilbert
Quoted 6 lines · John Weber
This is one of those drivers still broken due to the BIO changes (it still calls
io_request_lock()).Unfortunately, I only know enough to
s/io_request_lock/host->host_lock/g.
Quoted 7 lines
Quoted 1 line
I am afraid this requires a little more than this.
John,
Theppa_detect()must _not_ take thehost_locksemaphore as it is already taken by the mid level before it callsppa_detect(). [This will cause a lock up on an SMP machine.]
Not true in 2.5, detect is called without any locks held.
Quoted 3 lines
The
ppa_interrupt()should take thehost_locksemaphore before it callsscsi_done()(which calls up the scsi driver stack).
True
Signature · 1 line
Jens Axboe