Serial.c BUG 2.4.x-2.5x

Hi,

Who is responsible person for applying patches to main tree?

This time I decide to send 2.5.5 patch version:

@@ -2084,7 +2084,6 @@
    unsigned int        i,change_irq,change_port;
    int             retval = 0;
    unsigned long        new_port;
-    unsigned long        new_mem;
 
    if (copy_from_user(&new_serial,new_info,sizeof(new_serial)))
        return -EFAULT;

@@ -2094,7 +2093,6 @@
    new_port = new_serial.port;
    if (HIGH_BITS_OFFSET)
        new_port += (unsigned long) new_serial.port_high << 

HIGH_BITS_OFFSET;
- new_mem = new_serial.iomem_base;

    change_irq = new_serial.irq != state->irq;
    change_port = (new_port != ((int) state->port)) ||
@@ -2136,7 +2134,6 @@
        for (i = 0 ; i < NR_PORTS; i++)
            if ((state != &rs_table[i]) &&
                (rs_table[i].port == new_port) &&
-                (rs_table[i].iomem_base == new_mem) &&
                rs_table[i].type)
                return -EADDRINUSE;
    }

-------- Original Message --------
Subject: Serial.c Bug
Date: Wed, 14 Nov 2001 13:02:47 +0300
From: Roman Kurakin <[email protected]>
To: [email protected]

I have found a bug. It is in support of serial cards which uses
memory for
I/O insted of ports. I made a patch for serial.c and fix one place, but probably the problem like this one could be somewhere else.

If you try to use setserial with such cards you will get "Address in use" (-EADDRINUSE)

Best regards,
Kurakin Roman

Best regards,
Roman Kurakin