Skip to contentSkip to conversation

2.4.18-pre/rc broke PLIP

BUG Stas Sergeev 1 participant 1 message Mar 7, 2002 Network drivers

lore
Share & tools
lore
#0 lore raw

Hello.

Quoted 1 line · Tim Waugh

Does 2.4.19-pre2 not work for you?

I had the similar problem with plip at 2.4.18 and 2.4.19-pre2 seems to fix it for me (though I have seen a comments that it doesn't work for others).
But I had another problem with plip for years, which was not fixed by 2.4.19-pre2:
if I do ifdown plip0 and then ifup plip0, plip no longer works and the kernel logs timeouts, just like in 2.4.18.
To work around the problem I removed "DISABLE(dev-irq);" from plip_close(), and it works nice since.
So, if you are already on this, could you please look at the attached "patch" and make a real fix (if this is not the one already)?

drivers/net/plip.c +1 -2
@@ -163,7 +163,7 @@
 static int plip_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd);
 static int plip_preempt(void *handle);
 static void plip_wakeup(void *handle);
-
+
 enum plip_connection_state {
 	PLIP_CN_NONE=0,
 	PLIP_CN_RECEIVE,
@@ -1177,7 +1177,6 @@
 	struct plip_local *rcv = &nl->rcv_data;
 
 	netif_stop_queue (dev);
-	DISABLE(dev->irq);
 	synchronize_irq();
 
 	if (dev->irq == -1)