Skip to contentSkip to conversation

2.5.7 does not compile

DISCUSSION Jean-Luc Coulon 4 participants 5 messages Mar 21, 2002 – Mar 22, 2002 Network drivers

lore
Share & tools
lore

Jean-Luc Coulon

author
#0 lore raw

make[3]: Entering directory `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio'
gcc -D__KERNEL__ -I/usr/src/kernel-sources-2.5.7/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -DMODULE -DMODVERSIONS -include /usr/src/kernel-sources-2.5.7/include/linux/modversions.h -DKBUILD_BASENAME=scc -c -o scc.o scc.c
scc.c: In function `scc_net_rx':
scc.c:1664: `dev' undeclared (first use in this function) scc.c:1664: (Each undeclared identifier is reported only once scc.c:1664: for each function it appears in.)
make[3]: *** [scc.o] Error 1
make[3]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio' make[2]: *** [_modsubdir_net/hamradio] Error 2
make[2]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers' make[1]: *** [_mod_drivers] Error 2
make[1]: Leaving directory `/usr/src/kernel-sources-2.5.7'
make: *** [stamp-build] Error 2

-----------
Regards
Jean-Luc

#1 lore raw
Quoted 12 lines · On Thu, 21 Mar 2002 17:15:49 +0100 Jean-Luc Coulon…

make[3]: Entering directory `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio' gcc -D__KERNEL__ -I/usr/src/kernel-sources-2.5.7/include -Wall

(quoted diff) +0 -3
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -DMODULE -DMODVERSIONS -include

/usr/src/kernel-sources-2.5.7/include/linux/modversions.h -DKBUILD_BASENAME=scc -c -o scc.o scc.c
scc.c: In function `scc_net_rx':
scc.c:1664: `dev' undeclared (first use in this function) scc.c:1664: (Each undeclared identifier is reported only once scc.c:1664: for each function it appears in.)

Quoted 8 lines

make[3]: *** [scc.o] Error 1
make[3]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers/net/hamradio' make[2]: *** [_modsubdir_net/hamradio] Error 2
make[2]: Leaving directory `/usr/src/kernel-sources-2.5.7/drivers' make[1]: *** [_mod_drivers] Error 2
make[1]: Leaving directory `/usr/src/kernel-sources-2.5.7'
make: *** [stamp-build] Error 2

I hope this path will help you.

Quoted 3 lines

-----------
Regards
Jean-Luc

Evgeniy Polyakov ( s0mbre )

drivers/net/hamradio/scc.c renamed from drivers/net/hamradio/scc.c~ +1 -1
@@ -1661,7 +1661,7 @@
 	skb->pkt_type = PACKET_HOST;
 	
 	netif_rx(skb);
-	dev->last_rx = jiffies;
+	scc->dev->last_rx = jiffies;
 	return;
 }
#2 lore raw
In reply to Jean-Luc Coulon
Quoted 3 lines · Jean-Luc Coulon

-DKBUILD_BASENAME=scc -c -o scc.o scc.c
scc.c: In function `scc_net_rx':
scc.c:1664: `dev' undeclared (first use in this function)

Line should read..

scc->dev->last_rx = jiffies;

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#3 lore raw

Hallo,

It seeems to be the same bug in 6pack.c

So, I solved the problem in line 259 of 6pack.c by changing

dev->last_rx = jiffies;

into

sp->dev->last_rx = jiffies;

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Ursprüngliche Nachricht <<<<<<<<<<<<<<<<<<

Am 21.03.02, 17:45:01, schrieb [email protected] (Dave Jones) zum Thema Re:
2.5.7 does not compile:

Quoted 8 lines · Jean-Luc Coulon
Quoted 3 lines

-DKBUILD_BASENAME=scc -c -o scc.o scc.c
scc.c: In function `scc_net_rx':
scc.c:1664: `dev' undeclared (first use in this function)

Line should read..

scc->dev->last_rx = jiffies;

vy 73 de Hans-Joachim

Signature · 3 lines
 DD8NE   : Hans-Joachim Hetscher    IP-Adr. : [44.130.62.1] 
 amprNet : [email protected]     AX25    :DD8NE@DB0LJ.#RPL.DEU.EU 
 Internet: [email protected]     [email protected]
#4 lore raw
In reply to Jean-Luc Coulon
Quoted 5 lines · Hans-Joachim Hetscher

It seeems to be the same bug in 6pack.c
So, I solved the problem in line 259 of 6pack.c by changing dev->last_rx = jiffies;
into
sp->dev->last_rx = jiffies;

Yeah, it's a mystery how these broken versions of the fixes ended up in Jeff's tree. He took them from my tree, and my tree already has this and the previous corrected fix. really weird.

anyways, it's moot as all this is going to Jeff at the end of the week anyway for his pushing to Linus on his return the following week 8-)

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs