BKL in tiglusb release function

Is there a reason for the BKL to be used in tiglusb_release()? Are you worried about a race between open and release, or were you just following examples from other code?

I'm sure we can remove it safely. We might need another lock, but it won't be much.

Dave Hansen
[email protected]

@@ -128,7 +128,6 @@
 {
 	ptiglusb_t s = (ptiglusb_t) file->private_data;
 
-	lock_kernel ();
 	down (&s->mutex);
 	s->state = _stopped;
 	up (&s->mutex);

@@ -139,7 +138,6 @@
 		wake_up (&s->remove_ok);
 
 	s->opened = 0;
-	unlock_kernel ();
 
 	return 0;
 }

I was probably responsible for the removal from dabusb.c. In almost all cases that I found (over 60 of them), the BKL is not needed in the release function.

The use of s->mutex confuses me. In tiglusb_disconnect(), there is an up(). Where is the matching down? The comment for the mutex just says, "locks this struct". However, it is clear that it doesn't protect the whole structure. There are many places where structure members are accessed without the lock being held.

Dave Hansen
[email protected]