Skip to contentSkip to conversation

Q: calling SCpnt->scsi_done() on cancelled commands?

DISCUSSION Luben Tuikov 2 participants 2 messages Jun 22, 2002 – Jun 24, 2002 SCSI

lore
Share & tools
lore
#0 lore raw

It was recently mentioned that calling scsi_done() for cancelled commands doesn't matter.

I'd like to inquire as the the future of this condition?

I also noticed that aic7xxx also calls scsi_done() on cancelled commands (by the mid-layer, or otherwise).

In my code, I don't always know how the command was cancelled, it may have been cancelled by the middle layer or by other sources/means -- whenever this happens I just set a flag and let ``the command movers'' (from queue to queue) actually cancel the command (set the result code, if scsi_done() call scsi_done() and release the command to the mid-layer).

What is the future of calling scsi_done() on cancelled by the mid-layer commands?

TIA,

Signature · 1 line
Luben
#1 lore raw
Quoted 3 lines · Luben Tuikov

What is the future of calling scsi_done() on
cancelled by the mid-layer commands?

If I have anything to say about it, mandatory.

Signature · 4 lines
  Doug Ledford <[email protected]>     919-754-3700 x44233
         Red Hat, Inc. 
         1801 Varsity Dr.
         Raleigh, NC 27606