check for O_DIRECT capability in open(), not write()

PATCH In review Andrew Morton 1 participant 1 message Jul 4, 2002

Subsystems (4)

Memory management VFS Page cache File locking (flock() and fcntl()/lockf())

lore

Share & tools

lore

Andrew Morton

author

2002-07-04 23:50 UTC #0 lore raw

PATCH 14/27 check for O_DIRECT capability in open(), not write()

For O_DIRECT opens we're currently checking that the fs supports O_DIRECT at write(2)-time.

This is a forward-port of Andrea's patch which moves the check to open() time. Seems more sensible.

 fs/fcntl.c   |    5 +++++
 fs/open.c    |    8 ++++++++
 mm/filemap.c |    2 --
 3 files changed, 13 insertions(+), 2 deletions(-)

fs/fcntl.c renamed from fs/fcntl.c~o_direct-open-check +5 -0

@@ -245,6 +245,11 @@ static int setfl(int fd, struct file * f
 	}
 
 	if (arg & O_DIRECT) {
+		if (inode->i_mapping && inode->i_mapping->a_ops) {
+			if (!inode->i_mapping->a_ops->direct_IO)
+				return -EINVAL;
+		}
+
 		/*
 		 * alloc_kiovec() can sleep and we are only serialized by
 		 * the big kernel lock here, so abuse the i_sem to serialize

fs/open.c renamed from fs/open.c~o_direct-open-check +8 -0

@@ -665,6 +665,14 @@ struct file *dentry_open(struct dentry *
 	}
 	f->f_flags &= ~(O_CREAT | O_EXCL | O_NOCTTY | O_TRUNC);
 
+	/* NB: we're sure to have correct a_ops only after f_op->open */
+	if (f->f_flags & O_DIRECT) {
+		error = -EINVAL;
+		if (inode->i_mapping && inode->i_mapping->a_ops)
+			if (!inode->i_mapping->a_ops->direct_IO)
+				goto cleanup_all;
+	}
+
 	return f;
 
 cleanup_all:

mm/filemap.c renamed from mm/filemap.c~o_direct-open-check +0 -2

@@ -1121,8 +1121,6 @@ static ssize_t generic_file_direct_IO(in
 	retval = -EINVAL;
 	if ((offset & blocksize_mask) || (count & blocksize_mask))
 		goto out_free;
-	if (!mapping->a_ops->direct_IO)
-		goto out_free;
 
 	/*
 	 * Flush to disk exclusively the _data_, metadata must remain