leave truncate's orphaned pages on the LRU

PATCH In review Andrew Morton 1 participant 1 message Jul 17, 2002

Subsystems (3)

Memory management MGLRU MM reclaim

lore

Share & tools

lore

Andrew Morton

author

2002-07-17 05:18 UTC #0 lore raw

PATCH 2/13 leave truncate's orphaned pages on the LRU

Fix to the page reclaim code from Rik.

Anonymous pages which have buffers arise when truncate_complete_page()'s call to ->releasepage() failed. Those pages may still be mapped into process address spaces.

We should not remove them from the LRU, because that makes them unswappable and they hang around until process exit.

 vmscan.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

mm/vmscan.c renamed from mm/vmscan.c~rmap-lru-fix +2 ~~-10~~

@@ -235,19 +235,11 @@ shrink_cache(int nr_pages, zone_t *class
 
 			if (try_to_release_page(page, gfp_mask)) {
 				if (!mapping) {
-					/*
-					 * We must not allow an anon page
-					 * with no buffers to be visible on
-					 * the LRU, so we unlock the page after
-					 * taking the lru lock
-					 */
-					spin_lock(&pagemap_lru_lock);
-					unlock_page(page);
-					__lru_cache_del(page);
-
 					/* effectively free the page here */
+					unlock_page(page);
 					page_cache_release(page);
 
+					spin_lock(&pagemap_lru_lock);
 					if (--nr_pages)
 						continue;
 					break;