Skip to contentSkip to conversation

cs46xx fixes, some SDPIF input fixes, PCM multichannel refiine, some minor cleaups && bugfixes

PATCH In review Benny Sjostrand 2 participants 2 messages Aug 17, 2002 – Aug 19, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cs46xx fixes, some SDPIF input fixes, PCM multichannel refiine, some minor cleaups && bugfixes

Hi everyone!

This patch inlcudes the following changes on the cs46xx driver:
- SPDIF input, prevent the DSP to hang when umuting/muting the the SPDIF
input controll in mixer while playbakcing PCM.
- Fix missplaced #ifndef, "#ifdef CONFIG_SND_CS46XX_NEW_DSP" instead
of "#ifndef CONFIG_SND_CS46XX_NEW_DSP"
- Only Hercules Game Theater XP: turn on amplifier when driver is loaded and keep it on, to prevent *snap* sound when changing amplifier on -> off vs. off -> on.
- Refine on the PCM multichannel functionality, the *snap*'s sound when stopping and starting playback should be gone, by clearing DSP sample rate buffers, and
muting the PCM readers.
- More cleanups, remove unused code (#if 0 ... #endif)

The SPDIF input functionality consider it as _expermintal_, is still not good enough, sound sometimes distorcionated, and sometimes left and right channels are swapped.

I dont believe it's necesary to turn off the soundcard amplifier however the soundcard may not be used all the time. When turing on the amplifier it usually produces some undesired *snap* sound in speakers, if the amplifier is turned off each time PCM playback is stopped or started you will have that *snap* sound each time you start playbacb of any kind of sound.
I understand that on embedded devices and notebooks it can make sense turning of the soundcard amplifier to save power, but on a desktop computers power is usually not a problem, and the eg. the Game Theater XP card will never be used on anything else then a desktop computer, and then the amplifier can leaved on all the time without any problem.

Finally, I hope then you can hear when you playback sound that some undesirable noise *snaps* are gone now.

/Benny

#1 lore raw

Hi Benny,

now committed to cvs.
thanks!

Takashi

At Sat, 17 Aug 2002 17:02:36 +0200,

Quoted 36 lines · Benny Sjostrand

Hi everyone!

This patch inlcudes the following changes on the cs46xx driver:
- SPDIF input, prevent the DSP to hang when umuting/muting the the SPDIF input controll in mixer while playbakcing PCM.
- Fix missplaced #ifndef, "#ifdef CONFIG_SND_CS46XX_NEW_DSP" instead of "#ifndef CONFIG_SND_CS46XX_NEW_DSP"
- Only Hercules Game Theater XP: turn on amplifier when driver is loaded and keep it on, to
prevent *snap* sound when changing amplifier on -> off vs. off -> on.
- Refine on the PCM multichannel functionality, the *snap*'s sound when stopping and starting
playback should be gone, by clearing DSP sample rate buffers, and
muting the PCM readers.
- More cleanups, remove unused code (#if 0 ... #endif)

The SPDIF input functionality consider it as _expermintal_, is still not good enough, sound
sometimes distorcionated, and sometimes left and right channels are swapped.

I dont believe it's necesary to turn off the soundcard amplifier however the soundcard may
not be used all the time. When turing on the amplifier it usually produces some undesired *snap* sound
in speakers, if the amplifier is turned off each time PCM playback is stopped or started you will have
that *snap* sound each time you start playbacb of any kind of sound. I understand that on embedded devices and notebooks it can make sense turning of the soundcard
amplifier to save power, but on a desktop computers power is usually not a problem, and the eg.
the Game Theater XP card will never be used on anything else then a desktop computer, and
then the amplifier can leaved on all the time without any problem.

Quoted 5 lines

Finally, I hope then you can hear when you playback sound that some undesirable noise *snaps* are gone now.

/Benny

-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390