README 1ST - New problem logging macros (2.5.38)
Quoted 7 lines · Jeff Garzik
Review
Quoted 5 lines
} if (!request_mem_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0), "eepro100")) {(quoted diff) +1
-1- printk (KERN_ERR "eepro100: cannot reserve MMIO region\n"); + pci_problem(LOG_ERR, pdev, "eepro100: cannot reserve MMIO region");bloat, no advantage over printk
the advantage is that the string, which means plenty to the developer, but possibly much less to a Sys Admin, can be replaced with a more descriptive message, in the local language, by editing the formatting template in user-space. Since the printk messages were mapped directly over to the problem macros, then the issue here I think is how useful (or not) the info. is more so than what interface is used.
Quoted 11 lines
Review
Quoted 8 lines
if (sum != 0xBABA)(quoted diff) +3
-3- printk(KERN_WARNING "%s: Invalid EEPROM checksum %#4.4x, " - "check settings before activating this device!\n", - dev->name, sum); + net_pci_problem(LOG_WARNING, dev, pdev, "Invalid EEPROM checksum, " + "check settings before activating this device!", + detail(checksum, "%#4.4x", sum));bloat, checksum is purely informational, and can be obtained through other means
indeed. See previous comment.
Quoted 8 lines · Larry Kessler
Quoted 7 lines · Jeff Garzik
Quoted 6 lines
} if (!request_mem_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0), "eepro100")) {- printk (
KERN_ERR"eepro100: cannot reserve MMIO
region\n"); + pci_problem(LOG_ERR, pdev, "eepro100: cannot
reserve MMIO region");
Quoted 8 lines
Quoted 1 line
bloat, no advantage over printk
the advantage is that the string, which means plenty to the developer, but possibly much less to a Sys Admin, can be replaced with a more descriptive message, in the local language, by editing the formatting template in user-space. Since the printk messages were mapped directly over to the problem macros, then the issue here I think is how useful (or not) the info. is more so than what interface is used.
The problem is that printks are very easy, people won't easily switch to any other thing if it is hard to understand/use. If you can provide such easy interface, then ok.
Regarding translation problem: it makes life easier to admins, i.e. you enable Linux to be used by more stupid admins :-).
This race could not be won: Universe can always produce more remarkable idiots. Next time they will ask you "what is eepro100?" and if you say "it's a NIC, if you have intermittent link indicator problem try to reseat network cord..." they will ask "what is NIC and how to reseat the cord?" (btw, they will ask that in their native language). 8-(
Maybe requiring admins to know basic English is not that bad? --
vda
Quoted 2 lines · Denis Vlasenko
Regarding translation problem: it makes life easier to admins, i.e. you enable Linux to be used by more stupid admins :-).
Judging by the fact that most linux webservers were still running vunlerable versions of apache as of the last netcraft survey I'd say that goal has been already been hit. ;)
Gerhard
--
Gerhard Mack
<>< As a computer I find your faith in technology amusing.
Hi,
Quoted 3 lines · Gerhard Mack
Judging by the fact that most linux webservers were still running vunlerable versions of apache as of the last netcraft survey I'd say that goal has been already been hit. ;)
They all must go through hell and back at least twice to understand, you know... ;-)
Thunder
Signature · 1 line
assert(typeof((fool)->next) == typeof(fool)); /* wrong */