[2.5.43] (DAC960 compile failure)

DISCUSSION Kevin Brosius 2 participants 2 messages Oct 16, 2002 – Oct 17, 2002

Share & tools

Kevin Brosius

author

2002-10-16 23:17 UTC #0 lore raw

Quoted 8 lines

looking at that i realise that DAC960 code in 2.5.43
is not supposed to be tested:
======
#error I am a non-portable driver, please convert me to use the Documentation/DMA-mapping.txt interfaces
======
am i right?

Quoted 7 lines

the following weirdo appears in both gcc-3.1 and 3.2 (also in 2.5.42)
======
drivers/block/DAC960.c: In function `DAC960_DetectControllers':
drivers/block/DAC960.c:2465: `Controller' undeclared (first use in this function) drivers/block/DAC960.c:2465: (Each undeclared identifier is reported only once drivers/block/DAC960.c:2465: for each function it appears in.)

Yes, 2.5.42 did this also. It looks like gcc 3.2 doesn't like goto's which reference variables outside their native scope. You can move the Controller definition to full function scope to fix that error.

The DAC960 doesn't seem usable out of the stock kernel build though. You'll need to try patches previously posted to the list. (Which don't fully work for me either...)

Signature · 1 line

Kevin

Dave Olien

2002-10-17 00:30 UTC #1 lore raw

I just posted a DAC960 patch for 2.5.42. Tomorrow, I'll post a 2.5.43 patch. There are some minor changes needed (about three lines) for 2.5.43. See the patch posting regarding ACPI interactions.

I'd love to hear any good or bad results you have with these patches.

Thanks!

Dave Olien
Open Source Developement Lab

Quoted 31 lines · Kevin Brosius

Quoted 8 lines
looking at that i realise that DAC960 code in 2.5.43
is not supposed to be tested:
======
#error I am a non-portable driver, please convert me to use the Documentation/DMA-mapping.txt interfaces
======
am i right?
Quoted 7 lines
the following weirdo appears in both gcc-3.1 and 3.2 (also in 2.5.42)
======
drivers/block/DAC960.c: In function `DAC960_DetectControllers':
drivers/block/DAC960.c:2465: `Controller' undeclared (first use in this function) drivers/block/DAC960.c:2465: (Each undeclared identifier is reported only once drivers/block/DAC960.c:2465: for each function it appears in.)
Yes, 2.5.42 did this also. It looks like gcc 3.2 doesn't like goto's which reference variables outside their native scope. You can move the Controller definition to full function scope to fix that error.
The DAC960 doesn't seem usable out of the stock kernel build though. You'll need to try patches previously posted to the list. (Which don't fully work for me either...)
Signature · 6 lines
Kevin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/