module.c double init?

trivial Randy.Dunlap 1 participant 1 message Oct 24, 2002

Share & tools

Randy.Dunlap

author

2002-10-24 03:48 UTC #0 lore raw

in 2.5.44: kernel/module.c, function s_start(), there is:

	loff_t n = *pos;

and then same "n = *pos" is done in the for-loop initializer. It's just a thinko, right? or am I missing something?

Patch attached (to 2.5.44).

~Randy

kernel/module.c renamed from kernel/module.c.fixit +1 -1

@@ -1165,7 +1165,7 @@
 	if (!p)
 		return ERR_PTR(-ENOMEM);
 	lock_kernel();
-	for (v = module_list, n = *pos; v; n -= v->nsyms, v = v->next) {
+	for (v = module_list; v; n -= v->nsyms, v = v->next) {
 		if (n < v->nsyms) {
 			p->mod = v;
 			p->index = n;