scsi_debug 1.63 on lk 2.5.45

Attached is an addition to the patches on this driver that I've been posting recently. This one adds:
- slave_attach() and slave_detach()
- code clean up looking for a problem **
- more debug code allowing scanning cmd sequence to be seen in the log (when opts=1)

** after several (never the first) sequences of modprobe/rmmod on scsi_debug there is either:
- an oops during modprobe when driverfs tries to create a directory
- or a WARN_ON() at drivers/base/bus.c:277 during rmmod
[examples attached]

I'm not sure whether the problem is in scsi_debug, the scsi mid level or in the driverfs code. Grepping indicates that not many people currently utilize per driver parameters with driverfs (i.e. driver_create_file() and driver_remove_file()).

Doug Gilbert

Nov  3 17:32:39 fred kernel: scsi_debug: detect
Nov  3 17:32:39 fred kernel: Unable to handle kernel paging request at virtual address 5a5a5ab6
Nov  3 17:32:39 fred kernel:  printing eip:
Nov  3 17:32:39 fred kernel: c0168f36
Nov  3 17:32:39 fred kernel: *pde = 00000000
Nov  3 17:32:39 fred kernel: Oops: 0002
Nov  3 17:32:39 fred kernel: scsi_debug usbtest hid ehci-hcd usbcore  
Nov  3 17:32:39 fred kernel: CPU:    0
Nov  3 17:32:39 fred kernel: EIP:    0060:[<c0168f36>]    Not tainted
Nov  3 17:32:39 fred kernel: EFLAGS: 00010246
Nov  3 17:32:39 fred kernel: EIP is at driverfs_create_dir+0x56/0x100
Nov  3 17:32:39 fred kernel: eax: 00000000   ebx: 5a5a5ab6   ecx: 5a5a5ab6   edx: c0281b5d
Nov  3 17:32:39 fred kernel: esi: 5a5a5a5a   edi: dfdc2934   ebp: e085daac   esp: de353e80
Nov  3 17:32:39 fred kernel: ds: 0068   es: 0068   ss: 0068
Nov  3 17:32:39 fred kernel: Process modprobe (pid: 1060, threadinfo=de352000 task=dd8e0c40)
Nov  3 17:32:39 fred kernel: Stack: c0281b5d 00000077 00800000 c0381304 c0381300 e085da80 e085b120 c01b4318 
Nov  3 17:32:39 fred kernel:        e085daac c0381350 c01b2da1 e085da80 00000042 e085da80 00000000 e1061000 
Nov  3 17:32:39 fred kernel:        c01b3227 e085da80 00000000 e0858848 e085da80 00000000 c034ca6c 00000000 
Nov  3 17:32:39 fred kernel: Call Trace:
Nov  3 17:32:39 fred kernel:  [<e085da80>] sdebug_driverfs_driver+0x0/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e085b120>] driver_template+0x0/0x6c [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01b4318>] driver_make_dir+0x28/0x30
Nov  3 17:32:39 fred kernel:  [<e085daac>] sdebug_driverfs_driver+0x2c/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01b2da1>] bus_add_driver+0x81/0xa0
Nov  3 17:32:39 fred kernel:  [<e085da80>] sdebug_driverfs_driver+0x0/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e085da80>] sdebug_driverfs_driver+0x0/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01b3227>] driver_register+0x47/0x60
Nov  3 17:32:39 fred kernel:  [<e085da80>] sdebug_driverfs_driver+0x0/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e0858848>] scsi_debug_detect+0xd8/0x1c0 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e085da80>] sdebug_driverfs_driver+0x0/0x60 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e085b120>] driver_template+0x0/0x6c [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01f7b69>] scsi_register_host+0x39/0x200
Nov  3 17:32:39 fred kernel:  [<e085b120>] driver_template+0x0/0x6c [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01a6907>] copy_from_user+0x57/0x5c
Nov  3 17:32:39 fred kernel:  [<e0859799>] init_this_scsi_driver+0x19/0x40 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e085b120>] driver_template+0x0/0x6c [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01182b2>] sys_init_module+0x4c2/0x610
Nov  3 17:32:39 fred kernel:  [<e0857060>] E __insmod_scsi_debug_O/lib/modules/2.5.45/kernel/drivers/scsi/scsi_debug.o_M3DC4C18B_V132397+0x60/0x80 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<e0857060>] E __insmod_scsi_debug_O/lib/modules/2.5.45/kernel/drivers/scsi/scsi_debug.o_M3DC4C18B_V132397+0x60/0x80 [scsi_debug]
Nov  3 17:32:39 fred kernel:  [<c01073e3>] syscall_call+0x7/0xb
Nov  3 17:32:39 fred kernel: 
Nov  3 17:32:39 fred kernel: Code: ff 4e 5c 0f 88 89 04 00 00 89 3c 24 8b 45 00 89 44 24 04 e8 
Nov  3 17:44:30 fred login(pam_unix)[724]: session opened for user root by LOGIN(uid=0)
Nov  3 17:44:30 fred  -- root[724]: ROOT LOGIN ON tty4
Synchronizing SCSI cache: 
scsi_debug: slave_detach <0 0 0 0>
Badness in put_bus at drivers/base/bus.c:277
Call Trace:
 [<c01b2ed9>] put_bus+0x69/0x80
 [<c01b1ef3>] device_del+0x33/0x80
 [<c01f740b>] scsi_host_chk_and_release+0xdb/0x220
 [<c01a67e0>] __copy_to_user+0x30/0x50
 [<c01339dc>] buffered_rmqueue+0xac/0x120
 [<e085afe0>] driver_template+0x0/0x6c [scsi_debug]
 [<c01f7330>] scsi_host_chk_and_release+0x0/0x220
 [<c01f72be>] scsi_tp_for_each_host+0x3e/0x40
 [<e085afe0>] driver_template+0x0/0x6c [scsi_debug]
 [<c01f7d55>] scsi_unregister_host+0x25/0x70
 [<e085afe0>] driver_template+0x0/0x6c [scsi_debug]
 [<c01f7330>] scsi_host_chk_and_release+0x0/0x220
 [<e085972f>] exit_this_scsi_driver+0xf/0x20 [scsi_debug]
 [<e085afe0>] driver_template+0x0/0x6c [scsi_debug]
 [<c011910c>] free_module+0xac/0xc0
 [<c01184c3>] sys_delete_module+0x93/0x1b0
 [<c01073e3>] syscall_call+0x7/0xb

scsi_debug: [last] release
scsi : 0 hosts left.