Skip to contentSkip to conversation

2.4.20rc1 compile fix for t128.c

PATCH In review Andreas Steinmetz 2 participants 3 messages Nov 4, 2002 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.4.20rc1 compile fix for t128.c

The attached patch fixes a section type conflict error.

Signature · 2 lines
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH
drivers/scsi/t128.c renamed from drivers/scsi/t128.c.orig +1 -1
@@ -145,7 +145,7 @@
 static const struct signature {
 	const char *string;
 	int offset;
-} signatures[] __initdata = {
+} signatures[] = {
 	{"TSROM: SCSI BIOS, Version 1.12", 0x36},
 };
 
#1 lore raw
Quoted 1 line · Andreas Steinmetz

The attached patch fixes a section type conflict error.

Which compiler is showing this problem ?

drivers/scsi/t128.c line 149

Quoted 9 lines
drivers/scsi/t128.c renamed from drivers/scsi/t128.c.orig +1 -1
@@ -145,7 +145,7 @@
 static const struct signature {
 	const char *string;
 	int offset;
-} signatures[] __initdata = {
+} signatures[] = {
 	{"TSROM: SCSI BIOS, Version 1.12", 0x36},

Far better to lose the const

#2 lore raw

[forgot to cc lkml]

Quoted 7 lines · Alan Cox
Quoted 1 line · Andreas Steinmetz

The attached patch fixes a section type conflict error.

Which compiler is showing this problem ?

gcc 3.2

Quoted 14 lines

drivers/scsi/t128.c line 149

Quoted 10 lines
drivers/scsi/t128.c renamed from drivers/scsi/t128.c.orig +1 -1
@@ -145,7 +145,7 @@
 static const struct signature {
 	const char *string;
 	int offset;
-} signatures[] __initdata = {
+} signatures[] = {
 	{"TSROM: SCSI BIOS, Version 1.12", 0x36},

Far better to lose the const

any way you please.

Quoted 1 line
Signature · 2 lines
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH