Skip to contentSkip to conversation

M68k net local_irq*() updates

PATCH Manfred Spraul 1 participant 1 message Dec 27, 2002

lore
Share & tools
lore
#0 lore raw

Review

Quoted 10 lines


	skblen = skb->len;
(quoted diff) +1 -2
-	save_flags(flags);
-	cli();
+	local_irq_save(flags);

This would be the wrong thing (tm) for SMP: cli() gives a compile error for SMP, local_irq_save() creates the impression that the driver works on SMP systems. m68k is UP only, thus there is no need to fix it properly.

What about adding
+ #ifdef CONFIG_SMP
+ #error This driver does not work on SMP
+ #endif

Or a Kconfig dependency on !CONFIG_SMP?

--
Manfred