libipulog comments
Quoted 6 lines · Sebastian Zander
Hi Harald,
I have a some suggestions and a possible bug for libipulog.
1) Could you make
ipulog_strerror()non-static so someone else can use it?iptc_sterroris also non-static AFAIK.
Oh, it seems like you are using some very old version of libipulog. I'm sorry, I should never have put it into the 'iptables' package in the first place.
Please see the 'ulogd' package for the latest version of libipulog
(http://www.gnumonks.org/projects/ulogd) and:
cvs :pserver:[email protected]:/cvsroot ulogd
Quoted 4 lines
2) It would be cool if there is the option of setting the socket receive buffer to a higher value than default because for high speeds the default value is too small. I have a patch for an old libipulog and can send it to you if you think this could go in.
yes, this is definitely a good idea. Please see if your patch applies to the later libipulog versions (see above).
Quoted 6 lines
3) I think there is a bug in libipulog as in iptables 1.2.7a in the
ipulog_get_packet()function. The function seems to not always return NULL when its supposed to do. I made a patch ages ago and thought this was fixed but when I tried the new version it did not work. I think the problem was when you have multi and non-multi messages. But have a look at the patch.
It was fixed, but as stated, unfortunately there was an old libipulog in the iptables package.
I will remove it from the upcoming iptables-1.2.8 version.
Quoted 1 line
Thanx for your time.
Thanks for your contributions.
Quoted 2 lines
Cheers,
Sebastian
Signature · 5 lines
Live long and prosper - Harald Welte / [email protected] http://www.gnumonks.org/ ============================================================================ GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M- V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)