Skip to contentSkip to conversation

Dead code elimination in ip_conntrack_core.c

PATCH In review Stephane Ouellette 2 participants 2 messages Mar 15, 2003 – Mar 26, 2003

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Stephane Ouellette

author
#0 lore raw

PATCH 1/1 Dead code elimination in ip_conntrack_core.c

List members,

the following cosmetic patch removes dead code in
ip_conntrack_init() if CONFIG_SYSCTL is not defined. The patch applies against a plain 2.4.21-pre5-ac3 kernel.

Regards,

Stephane Ouellette

net/ipv4/netfilter/ip_conntrack_core.c +2 -0
@@ -1478,8 +1478,10 @@
 	ip_ct_attach = ip_conntrack_attach;
 	return ret;
 
+#ifdef CONFIG_SYSCTL
 err_free_ct_cachep:
 	kmem_cache_destroy(ip_conntrack_cachep);
+#endif /*CONFIG_SYSCTL*/
 err_free_hash:
 	vfree(ip_conntrack_hash);
 err_unreg_sockopt:
#1 lore raw
Quoted 5 lines · Stephane Ouellette

List members,

the following cosmetic patch removes dead code in
ip_conntrack_init() if CONFIG_SYSCTL is not defined. The patch applies against a plain 2.4.21-pre5-ac3 kernel.

thanks, I'm including your patch into 'pending'

Quoted 2 lines

Regards,
Stephane Ouellette

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie