kbuild and CONFIG_PROC_FS bug

PATCH In review Xose Vazquez Perez 2 participants 3 messages May 11, 2003 – May 12, 2003

Subsystems (6)

Media (V4L/DVB) SuperH Char and misc drivers SPARC + UltraSPARC (sparc/sparc64) +2 more subsystems

lore

Share & tools

lore

Xose Vazquez Perez

author

2003-05-11 01:07 UTC #0 lore raw

PATCH 1/1 kbuild and CONFIG_PROC_FS bug

hi guys,

There is a general error in some files, this was discussed time
ago: http://marc.theaimsgroup.com/?l=linux-kernel&m=104948738901849&w=2
Roman Zippel had a better solution than mine. And here it goes a patch for 2.4.21-rc2:

--cut--

arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200 renamed from arch/alpha/config.in 2003-05-11 02:53:23.000000000 +0200 +1 -1

diff -Nuar linux/arch/alpha/config.in linux.xose/arch/alpha/config.in
@@ -287,7 +287,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    choice 'Kernel core (/proc/kcore) format' \
        "ELF            CONFIG_KCORE_ELF        \
         A.OUT          CONFIG_KCORE_AOUT" ELF

arch/i386/config.in 2003-05-11 02:57:56.000000000 +0200 renamed from arch/i386/config.in 2003-05-11 02:53:24.000000000 +0200 +1 -1

diff -Nuar linux/arch/i386/config.in linux.xose/arch/i386/config.in
@@ -315,7 +315,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    choice 'Kernel core (/proc/kcore) format' \
        "ELF            CONFIG_KCORE_ELF        \
         A.OUT          CONFIG_KCORE_AOUT" ELF

arch/m68k/config.in 2003-05-11 03:00:15.000000000 +0200 renamed from arch/m68k/config.in 2003-05-11 02:53:25.000000000 +0200 +1 -1

diff -Nuar linux/arch/m68k/config.in linux.xose/arch/m68k/config.in
@@ -92,7 +92,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    choice 'Kernel core (/proc/kcore) format' \
        "ELF            CONFIG_KCORE_ELF        \
         A.OUT          CONFIG_KCORE_AOUT" ELF

arch/ppc/config.in 2003-05-11 03:00:02.000000000 +0200 renamed from arch/ppc/config.in 2003-05-11 02:53:26.000000000 +0200 +1 -1

diff -Nuar linux/arch/ppc/config.in linux.xose/arch/ppc/config.in
@@ -177,7 +177,7 @@
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 
 # only elf supported, a.out is not -- Cort
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
   define_bool CONFIG_KCORE_ELF y
 fi
 define_bool CONFIG_BINFMT_ELF y

arch/ppc64/config.in 2003-05-11 03:01:00.000000000 +0200 renamed from arch/ppc64/config.in 2003-05-11 02:53:28.000000000 +0200 +1 -1

diff -Nuar linux/arch/ppc64/config.in linux.xose/arch/ppc64/config.in
@@ -69,7 +69,7 @@
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 
 # only elf supported, a.out is not -- Cort
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    define_bool CONFIG_KCORE_ELF y
 fi

arch/sh/config.in 2003-05-11 03:00:43.000000000 +0200 renamed from arch/sh/config.in 2003-05-11 02:53:28.000000000 +0200 +1 -1

diff -Nuar linux/arch/sh/config.in linux.xose/arch/sh/config.in
@@ -205,7 +205,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    choice 'Kernel core (/proc/kcore) format' \
        "ELF            CONFIG_KCORE_ELF        \
         A.OUT          CONFIG_KCORE_AOUT" ELF

arch/sparc/config.in 2003-05-11 02:59:42.000000000 +0200 renamed from arch/sparc/config.in 2003-05-11 02:53:28.000000000 +0200 +1 -1

diff -Nuar linux/arch/sparc/config.in linux.xose/arch/sparc/config.in
@@ -65,7 +65,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    define_bool CONFIG_KCORE_ELF y
 fi
 tristate 'Kernel support for a.out binaries' CONFIG_BINFMT_AOUT

arch/sparc64/config.in 2003-05-11 03:00:30.000000000 +0200 renamed from arch/sparc64/config.in 2003-01-16 04:26:24.000000000 +0100 +1 -1

diff -Nuar linux/arch/sparc64/config.in linux.xose/arch/sparc64/config.in
@@ -64,7 +64,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    define_bool CONFIG_KCORE_ELF y
 fi
 bool 'Kernel support for Linux/Sparc 32bit binary compatibility' CONFIG_SPARC32_COMPAT

arch/x86_64/config.in 2003-05-11 03:01:15.000000000 +0200 renamed from arch/x86_64/config.in 2003-05-11 02:53:29.000000000 +0200 +1 -1

diff -Nuar linux/arch/x86_64/config.in linux.xose/arch/x86_64/config.in
@@ -101,7 +101,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    define_bool CONFIG_KCORE_ELF y
 fi
 #tristate 'Kernel support for a.out binaries' CONFIG_BINFMT_AOUT

drivers/char/ftape/Config.in 2003-05-11 02:57:14.000000000 +0200 renamed from drivers/char/ftape/Config.in 2003-01-16 04:26:28.000000000 +0100 +1 -1

diff -Nuar linux/drivers/char/ftape/Config.in linux.xose/drivers/char/ftape/Config.in
@@ -10,7 +10,7 @@
 if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
    int '  Number of ftape buffers (EXPERIMENTAL)' CONFIG_FT_NR_BUFFERS 3
 fi
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
    bool '  Enable procfs status report (+2kb)' CONFIG_FT_PROC_FS
 fi
 choice 'Debugging output'                      \

drivers/media/radio/Config.in 2003-05-11 02:57:39.000000000 +0200 renamed from drivers/media/radio/Config.in 2003-05-11 02:53:34.000000000 +0200 +1 -1

diff -Nuar linux/drivers/media/radio/Config.in linux.xose/drivers/media/radio/Config.in
@@ -40,7 +40,7 @@
       hex '    Trust i/o port (usually 0x350 or 0x358)' CONFIG_RADIO_TRUST_PORT 350
    fi
    dep_tristate '  Typhoon Radio (a.k.a. EcoRadio)' CONFIG_RADIO_TYPHOON $CONFIG_VIDEO_DEV
-   if [ "$CONFIG_PROC_FS" = "y" ]; then
+   if [ "$CONFIG_PROC_FS" != "n" ]; then
       if [ "$CONFIG_RADIO_TYPHOON" != "n" ]; then
          bool '    Support for /proc/radio-typhoon' CONFIG_RADIO_TYPHOON_PROC_FS
       fi

--end--

-thanks-

regards,

Signature · 1 line

Galiza nin perdoa nin esquence. Governo demision!

Adrian Bunk

2003-05-12 21:14 UTC #1 lore raw

Quoted 12 lines · Xose Vazquez Perez

hi guys,
There is a general error in some files, this was discussed time
ago: http://marc.theaimsgroup.com/?l=linux-kernel&m=104948738901849&w=2
Roman Zippel had a better solution than mine. And here it goes a patch for 2.4.21-rc2:
--cut--
diff -Nuar linux/arch/alpha/config.in linux.xose/arch/alpha/config.in

arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200 line 290

Quoted 6 lines

arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200 renamed from arch/alpha/config.in 2003-05-11 02:53:23.000000000 +0200 +1 -1
@@ -287,7 +287,7 @@
 bool 'System V IPC' CONFIG_SYSVIPC
 bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT
 bool 'Sysctl support' CONFIG_SYSCTL
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
...

CONFIG_PROC_FS is a bool, I don't see anything that changes with your patch.

Quoted 1 line

regards,

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Xose Vazquez Perez

author

2003-05-12 21:59 UTC #2 lore raw

Quoted 6 lines · Adrian Bunk

Quoted 6 lines
diff -Nuar linux/arch/alpha/config.in linux.xose/arch/alpha/config.in
arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200 renamed from arch/alpha/config.in 2003-05-11 02:53:23.000000000 +0200 +0 -0
@@ -287,7 +287,7 @@
bool 'System V IPC' CONFIG_SYSVIPC
bool 'BSD Process Accounting' CONFIG_BSD_PROCESS_ACCT

Quoted 8 lines

arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200
Quoted 4 lines
bool 'Sysctl support' CONFIG_SYSCTL
arch/alpha/config.in 2003-05-11 02:59:04.000000000 +0200 renamed from arch/alpha/config.in 2003-05-11 02:53:23.000000000 +0200 +1 -1
-if [ "$CONFIG_PROC_FS" = "y" ]; then
+if [ "$CONFIG_PROC_FS" != "n" ]; then
...
CONFIG_PROC_FS is a bool, I don't see anything that changes with your patch.

read this: http://marc.theaimsgroup.com/?l=linux-kernel&m=104948236128373&w=2
it is _necessary_, Roman aka kbuild guru said it.
But if you have other idea...

regards,

Signature · 1 line

Galiza nin perdoa nin esquence. Governo demision!